Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More idmap fixes #382

Merged
merged 3 commits into from
Jan 11, 2024
Merged

More idmap fixes #382

merged 3 commits into from
Jan 11, 2024

Commits on Jan 10, 2024

  1. shared/idmap: Don't change the json format

    This is needed to avoid a breaking change to the volatile keys in Incus
    and potentially in other tools using the serialized JSON format.
    
    Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
    stgraber committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    c0448c1 View commit details
    Browse the repository at this point in the history
  2. shared/idmap: Document AddSafe and fix double records

    This properly documents the working of AddSafe as well as fixes an issue
    where a new entry that's of both UID and GID types could intersect with
    more than one entry (if mixed with entries that aren't both UID and GID).
    
    Simply keep track of whether the entry was already added and if it did,
    process the intersection but don't add the entry again.
    
    Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
    stgraber committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    64afc16 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. incusd: Update instance_test for shared/idmap fix

    Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
    stgraber committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    fe01631 View commit details
    Browse the repository at this point in the history