Instance migration related fixes #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an issue I hit during a recent live demo on a stream, basically if anything causes a failure during instance creation the OpenFGA record was kept around, making the retry similarly fail. This is particularly visible during migrations as Incus will attempt multiple instance creations in a row to try to find a working source/destination address. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are a couple of issues I ran into during a live demo in a recent live stream.
The first is yet another OpenFGA revert issue, apparently I had missed those code paths in my recent fixes. The second is a trivial logic bug in the client which was making the client always take the same-server code path when dealing with a project target, even with the source and target servers were different.