-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description field on certificate entries #297
Conversation
|
9e184fa
to
cb1857a
Compare
internal/server/db/cluster/update.go
Outdated
// updateFromV69 adds description column to certificate. | ||
func updateFromV69(ctx context.Context, tx *sql.Tx) error { | ||
q := ` | ||
ALTER TABLE certificates ADD COLUMN description TEXT NOT NULL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to fail to run on any Incus system that has a DB entry in the certificates table.
This is going to need a DEFAULT ""
to avoid this problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, that's right. Fixed.
Looks good, just that small schema issue and it should be good to go. |
Signed-off-by: Piotr Resztak <piotr.resztak@gmail.com>
Signed-off-by: Piotr Resztak <piotr.resztak@gmail.com>
Signed-off-by: Piotr Resztak <piotr.resztak@gmail.com>
Signed-off-by: Piotr Resztak <piotr.resztak@gmail.com>
Signed-off-by: Piotr Resztak <piotr.resztak@gmail.com>
cb1857a
to
ab98775
Compare
Thanks @presztak! |
Adds description field on certificate entries and possibility to modify description using API.
Closes #246