Import LXD changes #237
Merged
Import LXD changes #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the Stdout and Stderr fields to be of type io.Writer instead of io.WriteCloser since `Close()` is never called on these fields. Fixes #12197 Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
This adds a new function which checks whether the given path has subvolumes. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
This replaces `getSubvolumes` with `hasSubvolumes` when creating a new storage pool as the caller isn't interested in what the subvolumes are. It also fixes a regression which caused storage pools with `source` set to an existing subvolume to fail when being created. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
This changes the Stdin field to be of type io.Reader instead of io.ReadCloser. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
…kward compat Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
…me mounting from setupNvram Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
volatile.apply_nvram has a bool type, but declared as a string. Let's fix that for consistency sake. Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
… mirror finishes in ExecInstance Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Not since ce2aad50cbc75a6dfce5d2f1e78a65024b01bb19 Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…irrorRead Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…ckets" This reverts commit 781905a01b68d68b4071643d947b75004ea4fad9. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…for exec control and stdin channels Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.