Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared/cliconfig: Nicer error on missing socket #185

Merged
merged 1 commit into from
Oct 22, 2023
Merged

shared/cliconfig: Nicer error on missing socket #185

merged 1 commit into from
Oct 22, 2023

Conversation

stgraber
Copy link
Member

Closes #184

@stgraber
shared/cliconfig: Nicer error on missing socket
c01e909 
Closes lxc#184

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@brauner brauner merged commit 2ae4425 into lxc:main Oct 22, 2023
24 of 25 checks passed
@gabrielmougard gabrielmougard mentioned this pull request Oct 23, 2023
Merged
@iBug
Copy link

iBug commented Jan 6, 2024

Not the best way to do this. I got confused by the error message when running incus as an unprivileged user that doesn't belong to the incus-admin group, but I knew the Incus server was running properly.

It would be much better if this had differentiated between ENOENT, EACCES and ECONNREFUSED. In my case it's EACCES, which should not be interpreted as "server not running".

@stgraber
Copy link
Member Author

stgraber commented Jan 6, 2024

#371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message about failed launch
3 participants
@stgraber @iBug @brauner