incus-user: keep track of socket path used to connect to the server #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic used to figure out the correct Unix socket path for access to the demon in `client.ConnectIncusUnix()` was fixed in in d8b78d5 to account for use of /run/incus/unix.socket as an alternative socket location. However, the proxying code of incus-user was not updated when the fix was introduced. As a result, even if initial connection to the server and the configuration queries were successful, the actual attempt to proxy a client request would fail while trying to connect to /var/lib/incus/unix.socket regardless of prior findings. Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
stgraber
approved these changes
Jan 27, 2025
stgraber
changed the title
|
Looks good, I'll re-try the failing test tomorrow and that will get this one merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic used to figure out the correct Unix socket path for access to
the demon in
client.ConnectIncusUnix()was fixed in ind8b78d5 to account for use of
/run/incus/unix.socket as an alternative socket location. However, the
proxying code of incus-user was not updated when the fix was
introduced. As a result, even if initial connection to the server and
the configuration queries were successful, the actual attempt to proxy
a client request would fail while trying to connect to
/var/lib/incus/unix.socket regardless of prior findings.