tests: Add incus-user test #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgraber
force-pushed
the
user
branch
4 times, most recently
from
c665b3e
to
d5b9582
Compare
hallyn
reviewed
Oct 11, 2023
test/suites/incus_user.sh
Outdated
|
|
||
| incus-user --group nogroup & | ||
| USER_PID="$!" | ||
| sleep 3 |
There was a problem hiding this comment.
Seems fragile - given how slow github runners can sometimes be, it would seem worth checking availability over the socket in a loop, if possible.
hallyn
approved these changes
Oct 11, 2023
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
hallyn
reviewed
Oct 12, 2023
Closes lxc#142 Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
hallyn
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142