Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incusd/internal/server/instance/drivers: support for Chimera Linux edk2 pkg layout #1298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mwyvr
Copy link

@mwyvr mwyvr commented Oct 9, 2024

Incus is packaged for Chimera Linux; this addition provides support for edk2 filenames as packaged by Chimera Linux.

Have built and tested on x86_64 arch / Chimera Linux (musl libc); both containers and virtual machines (security.secureboot=false) perform as expected.

@mwyvr mwyvr requested a review from stgraber as a code owner October 9, 2024 05:41
@mwyvr
Copy link
Author

mwyvr commented Oct 9, 2024

PS, I can do a PR for https://linuxcontainers.org/incus/docs/main/installing/ but will provide them here too.

I'd prefer holding off submitting a PR for install docs because this particular PR is key to making Incus properly functional without manual workarounds on Chimera Linux, and, with this change having been accepted, hope/expect to see Incus move from the Chimera user to main repository.

Install:

To install Incus on Chimera Linux, ensure the user repository has been added to the system:

apk add chimera-repo-user

Then add the incus package; this will install other dependencies including incus-client. Enable the service.

apk add incus
dinitctl enable incus

To run virtual machines, also add the EDK2 firmware. Chimera Linux currently does not provide complete support for Secure Boot, so virtual machines must be launched with this feature disabled.

apk add qemu-edk2-firmware
# example: launch virtual machine with secureboot disabled:
# incus launch images:debian/12 --vm -c security.secureboot=false

Report packaging issues here.

@hallyn
Copy link
Member

hallyn commented Oct 11, 2024

Thanks, looks good to me.

I do have to ask though - what would be the chances of just having the incus package in chimera linux add symlinks to the names incus already knows them by?

Also, I wonder if we should start adding comments to each line to say which distros they are intended to support

@hallyn
Copy link
Member

hallyn commented Oct 11, 2024

Interesting, SOB check wants the same username that shows up in From. I didn't know it checked for that...

@mwyvr
Copy link
Author

mwyvr commented Oct 11, 2024 via email

@mwyvr
Copy link
Author

mwyvr commented Oct 11, 2024

Interesting, SOB check wants the same username that shows up in From. I didn't know it checked for that...

What's the right way to correct this? Both email addresses are deliverable to me, btw; since this I had github verify the github@. I'll ensure I've used git@mike... in the future, the commit comment was a typo on my part.

@hallyn
Copy link
Member

hallyn commented Oct 11, 2024

Indeed, that's what I had been doing, manually. I rationalized submitting these changes as Chimera Linux maintainers have used the package/filenames/descriptors from the qemu package, so at least they will match if other distributions have or will follow suit.

Oh, that seems reasonable.

@hallyn
Copy link
Member

hallyn commented Oct 11, 2024

Interesting, SOB check wants the same username that shows up in From. I didn't know it checked for that...

What's the right way to correct this? Both email addresses are deliverable to me, btw; since this I had github verify the github@. I'll ensure I've used git@mike... in the future, the commit comment was a typo on my part.

Well the easiest way for you is probably to just make the SOB line be

Signed-off-by: Mike Watkins git@mikewatkins.ca

Rather than do a git commit --amend --author=...github...

…x edk2 pkg file names

Signed-off-by: Mike Watkins <git@mikewatkins.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants