-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incusd/internal/server/instance/drivers: support for Chimera Linux edk2 pkg layout #1298
base: main
Are you sure you want to change the base?
Conversation
PS, I can do a PR for https://linuxcontainers.org/incus/docs/main/installing/ but will provide them here too. I'd prefer holding off submitting a PR for install docs because this particular PR is key to making Incus properly functional without manual workarounds on Chimera Linux, and, with this change having been accepted, hope/expect to see Incus move from the Chimera user to main repository. Install: To install Incus on Chimera Linux, ensure the
Then add the
To run virtual machines, also add the EDK2 firmware. Chimera Linux currently does not provide complete support for Secure Boot, so virtual machines must be launched with this feature disabled.
Report packaging issues here. |
Thanks, looks good to me. I do have to ask though - what would be the chances of just having the incus package in chimera linux add symlinks to the names incus already knows them by? Also, I wonder if we should start adding comments to each line to say which distros they are intended to support |
Interesting, SOB check wants the same username that shows up in From. I didn't know it checked for that... |
On Fri, 2024-10-11 at 12:32 -0700, Serge Hallyn wrote:
Thanks, looks good to me.
I do have to ask though - what would be the chances of just having
the incus package in chimera linux add symlinks to the names incus
already knows them by?
Indeed, that's what I had been doing, manually. I rationalized
submitting these changes as Chimera Linux maintainers have used the
package/filenames/descriptors from the qemu package, so at least they
will match if other distributions have or will follow suit.
https://github.com/qemu/qemu/tree/05adb38839ba656c7383a548b460d95c91e2febe/pc-bios
Also, I wonder if we should start adding comments to each line to say
which distros they are intended to support
Seems like a good idea; after looking at Ubuntu/Debian, Fedora, Arch
and openSUSE (which should package Incus but doesn't to my
disappointment) they are all rather unique combos of paths and EDK2
filenames.
|
What's the right way to correct this? Both email addresses are deliverable to me, btw; since this I had github verify the github@. I'll ensure I've used git@mike... in the future, the commit comment was a typo on my part. |
Oh, that seems reasonable. |
Well the easiest way for you is probably to just make the SOB line be Signed-off-by: Mike Watkins git@mikewatkins.ca Rather than do a git commit --amend --author=...github... |
…x edk2 pkg file names Signed-off-by: Mike Watkins <git@mikewatkins.ca>
cca6fec
to
1c64a0b
Compare
Incus is packaged for Chimera Linux; this addition provides support for edk2 filenames as packaged by Chimera Linux.
Have built and tested on x86_64 arch / Chimera Linux (musl libc); both containers and virtual machines (security.secureboot=false) perform as expected.