Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incusd/storage/lvm: Retry setactivation skip for busy environments #1164

Merged
merged 1 commit into from
Aug 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/server/storage/drivers/driver_lvm_utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ func (d *lvm) createLogicalVolume(vgName, thinPoolName string, vol Volume, makeT
if isRecent {
// Disable auto activation of volume on LVM versions that support it.
// Must be done after volume create so that zeroing and signature wiping can take place.
_, err := subprocess.RunCommand("lvchange", "--setactivationskip", "y", volDevPath)
_, err := subprocess.TryRunCommand("lvchange", "--setactivationskip", "y", volDevPath)
if err != nil {
return fmt.Errorf("Failed to set activation skip on LVM logical volume %q: %w", volDevPath, err)
}
Expand Down
Loading