Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return filesystem metrics for filesystems that can't report instance-specific usage #968

Closed
stgraber opened this issue Jul 1, 2024 · 0 comments
Closed

Don't return filesystem metrics for filesystems that can't report instance-specific usage #968

stgraber opened this issue Jul 1, 2024 · 0 comments
Labels
Bug Confirmed to be a bug Easy Good for new contributors
Milestone
incus-6.3

Comments

@stgraber
Copy link
Member

stgraber commented Jul 1, 2024

Reported at zabbly/incus#47

Basically filesystems that don't provide us with dataset/subvolume/volume/whatever specific metrics currently return the total size and available bytes of the entire pool rather than just the one instance. This causes some rather confusing output in things like Grafana and incus top.

It'd be preferable to just not have the metric exposed in such cases so we end up with a missing value instead.
@stgraber stgraber added Bug Confirmed to be a bug Easy Good for new contributors labels Jul 1, 2024
@stgraber stgraber added this to the incus-6.3 milestone Jul 1, 2024
@hallyn hallyn closed this as completed in 832b02c Jul 11, 2024
stgraber added a commit that referenced this issue Jul 18, 2024
@stgraber
incusd/instance/lxc: Don't report filesystem metrics when no per-inst…
b83b353 
…ance value

Closes #968

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Confirmed to be a bug Easy Good for new contributors
Milestone
incus-6.3
Development

No branches or pull requests
1 participant
@stgraber