Keep ubuntu example netplan setting consistent #859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, we usually want the example to be kept close to the production YAML where we do have the two different interface names. This change does make the example look simpler but isn't representative of how most images are produced. |
|
That said we should refresh the example as I suspect things have changed a bit in the production YAML file. |
nanjj
added a commit
to nanjj/lxc-ci
that referenced
this pull request
Jun 24, 2024
Related with PR lxc/distrobuilder#859. Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
`dnf update` equivalents to `apt install --only-upgrade` so changed it to `dnf check-update` the rarely used command since usually package cache automatically updated. Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for both container and vm.