-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image,shared: Allow specifying compression level #680
Conversation
@gnustomp a couple of things are still missing:
Also, I believe we should do early validation here, here, here, and here. Some builds take quite a while, and it'd be a shame if they failed late due to a typo in the compression string. |
Thanks for the feedback, @monstermunchkin. I have refactored the PR so that it supports specifying levels for most compression methods and have added tests.
|
Allow specifying compression levels when the underlying tool or mksquashfs understands it. For example, gzip-1 or zstd-22. Compression levels are checked pre-run. Signed-off-by: James Ye <jamesye@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. Just a few changes regarding lzo
and lzop
to avoid confusion.
Let's add it to this PR, just a separate commit. |
mksquashfs accepts "lzo" for compression, but the standalone tool is named "lzop". Accept both "lzo" and "lzop" to improve handling of LZO-compressed LXD split images and for convenience. Signed-off-by: James Ye <jamesye@google.com>
Done. |
Allow specifying compression levels when the underlying tool or mksquashfs understands it. For example, gzip-1 or zstd-22. Compression levels are checked pre-run.
Signed-off-by: James Ye jamesye@google.com