Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated io/ioutil package #659

Merged
merged 3 commits into from
Aug 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions distrobuilder/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ import (
"errors"
"fmt"
"io"
"io/ioutil"
"os"
"os/signal"
"path/filepath"
Expand Down Expand Up @@ -161,7 +160,7 @@ func main() {

// Create temp directory if the cache directory isn't explicitly set
if globalCmd.flagCacheDir == "" {
dir, err := ioutil.TempDir("/var/cache", "distrobuilder.")
dir, err := os.MkdirTemp("/var/cache", "distrobuilder.")
if err != nil {
fmt.Fprintf(os.Stderr, "Failed to create cache directory: %s\n", err)
os.Exit(1)
Expand Down Expand Up @@ -762,5 +761,5 @@ if [ "${nm_exists}" -eq 1 ]; then
fi
`
os.MkdirAll("/etc/systemd/system-generators", 0755)
ioutil.WriteFile("/etc/systemd/system-generators/lxc", []byte(content), 0755)
os.WriteFile("/etc/systemd/system-generators/lxc", []byte(content), 0755)
}
13 changes: 6 additions & 7 deletions distrobuilder/main_repack-windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"encoding/hex"
"errors"
"fmt"
"io/ioutil"
"net/http"
"os"
"os/exec"
Expand Down Expand Up @@ -216,7 +215,7 @@ func (c *cmdRepackWindows) run(cmd *cobra.Command, args []string, overlayDir str

var sourcesDir string

entries, err := ioutil.ReadDir(overlayDir)
entries, err := os.ReadDir(overlayDir)
if err != nil {
return fmt.Errorf("Failed to read directory %q: %w", overlayDir, err)
}
Expand All @@ -228,7 +227,7 @@ func (c *cmdRepackWindows) run(cmd *cobra.Command, args []string, overlayDir str
}
}

entries, err = ioutil.ReadDir(sourcesDir)
entries, err = os.ReadDir(sourcesDir)
if err != nil {
return fmt.Errorf("Failed to read directory %q: %w", sourcesDir, err)
}
Expand Down Expand Up @@ -404,7 +403,7 @@ func (c *cmdRepackWindows) getWindowsDirectories(wimPath string) (map[string]str
driverStorePath := ""
dirs := make(map[string]string)

entries, err := ioutil.ReadDir(wimPath)
entries, err := os.ReadDir(wimPath)
if err != nil {
return nil, err
}
Expand All @@ -421,7 +420,7 @@ func (c *cmdRepackWindows) getWindowsDirectories(wimPath string) (map[string]str
}
}

entries, err = ioutil.ReadDir(windowsPath)
entries, err = os.ReadDir(windowsPath)
if err != nil {
return nil, err
}
Expand All @@ -445,7 +444,7 @@ func (c *cmdRepackWindows) getWindowsDirectories(wimPath string) (map[string]str
}
}

entries, err = ioutil.ReadDir(system32Path)
entries, err = os.ReadDir(system32Path)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -474,7 +473,7 @@ func (c *cmdRepackWindows) getWindowsDirectories(wimPath string) (map[string]str
}
}

entries, err = ioutil.ReadDir(driverStorePath)
entries, err = os.ReadDir(driverStorePath)
if err != nil {
return nil, err
}
Expand Down
3 changes: 1 addition & 2 deletions generators/copy.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package generators

import (
"fmt"
"io/ioutil"
"os"
"path/filepath"
"strings"
Expand Down Expand Up @@ -42,7 +41,7 @@ func (g *copy) Run() error {
destPath = filepath.Join(g.sourceDir, g.defFile.Path)
}

dirFiles, err := ioutil.ReadDir(filepath.Dir(srcPath))
dirFiles, err := os.ReadDir(filepath.Dir(srcPath))
if err != nil {
return fmt.Errorf("Failed to read directory %q: %w", filepath.Dir(srcPath), err)
}
Expand Down
7 changes: 3 additions & 4 deletions generators/hosts.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package generators

import (
"fmt"
"io/ioutil"
"os"
"path/filepath"
"strings"
Expand All @@ -26,7 +25,7 @@ func (g *hosts) RunLXC(img *image.LXCImage, target shared.DefinitionTargetLXC) e
}

// Read the current content
content, err := ioutil.ReadFile(filepath.Join(g.sourceDir, g.defFile.Path))
content, err := os.ReadFile(filepath.Join(g.sourceDir, g.defFile.Path))
if err != nil {
return fmt.Errorf("Failed to read file %q: %w", filepath.Join(g.sourceDir, g.defFile.Path), err)
}
Expand Down Expand Up @@ -77,7 +76,7 @@ func (g *hosts) RunLXD(img *image.LXDImage, target shared.DefinitionTargetLXD) e
}

// Read the current content
content, err := ioutil.ReadFile(filepath.Join(g.sourceDir, g.defFile.Path))
content, err := os.ReadFile(filepath.Join(g.sourceDir, g.defFile.Path))
if err != nil {
return fmt.Errorf("Failed to read file %q: %w", filepath.Join(g.sourceDir, g.defFile.Path), err)
}
Expand All @@ -91,7 +90,7 @@ func (g *hosts) RunLXD(img *image.LXDImage, target shared.DefinitionTargetLXD) e
}

// Write the template
err = ioutil.WriteFile(filepath.Join(templateDir, "hosts.tpl"), content, 0644)
err = os.WriteFile(filepath.Join(templateDir, "hosts.tpl"), content, 0644)
if err != nil {
return fmt.Errorf("Failed to write file %q: %w", filepath.Join(templateDir, "hosts.tpl"), err)
}
Expand Down
19 changes: 9 additions & 10 deletions generators/lxd-agent.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"bufio"
"errors"
"fmt"
"io/ioutil"
"os"
"path/filepath"
"strings"
Expand Down Expand Up @@ -91,7 +90,7 @@ WantedBy=multi-user.target

path := filepath.Join(g.sourceDir, systemdPath, "system", "lxd-agent.service")

err := ioutil.WriteFile(path, []byte(lxdAgentServiceUnit), 0644)
err := os.WriteFile(path, []byte(lxdAgentServiceUnit), 0644)
if err != nil {
return fmt.Errorf("Failed to write file %q: %w", path, err)
}
Expand Down Expand Up @@ -144,7 +143,7 @@ chown -R root:root "${PREFIX}"

path = filepath.Join(g.sourceDir, systemdPath, "lxd-agent-setup")

err = ioutil.WriteFile(path, []byte(lxdAgentSetupScript), 0755)
err = os.WriteFile(path, []byte(lxdAgentSetupScript), 0755)
if err != nil {
return fmt.Errorf("Failed to write file %q: %w", path, err)
}
Expand All @@ -156,7 +155,7 @@ chown -R root:root "${PREFIX}"
}

lxdAgentRules := `ACTION=="add", SYMLINK=="virtio-ports/org.linuxcontainers.lxd", TAG+="systemd", ACTION=="add", RUN+="/bin/systemctl start lxd-agent.service"`
err = ioutil.WriteFile(filepath.Join(g.sourceDir, udevPath, "99-lxd-agent.rules"), []byte(lxdAgentRules), 0400)
err = os.WriteFile(filepath.Join(g.sourceDir, udevPath, "99-lxd-agent.rules"), []byte(lxdAgentRules), 0400)
if err != nil {
return fmt.Errorf("Failed to write file %q: %w", filepath.Join(g.sourceDir, udevPath, "99-lxd-agent.rules"), err)
}
Expand Down Expand Up @@ -184,7 +183,7 @@ depend() {
}
`

err := ioutil.WriteFile(filepath.Join(g.sourceDir, "/etc/init.d/lxd-agent"), []byte(lxdAgentScript), 0755)
err := os.WriteFile(filepath.Join(g.sourceDir, "/etc/init.d/lxd-agent"), []byte(lxdAgentScript), 0755)
if err != nil {
return fmt.Errorf("Failed to write file %q: %w", filepath.Join(g.sourceDir, "/etc/init.d/lxd-agent"), err)
}
Expand All @@ -210,7 +209,7 @@ start_pre() {
}
`

err = ioutil.WriteFile(filepath.Join(g.sourceDir, "/etc/init.d/lxd-agent-9p"), []byte(lxdConfigShareMountScript), 0755)
err = os.WriteFile(filepath.Join(g.sourceDir, "/etc/init.d/lxd-agent-9p"), []byte(lxdConfigShareMountScript), 0755)
if err != nil {
return fmt.Errorf("Failed to write file %q: %w", filepath.Join(g.sourceDir, "/etc/init.d/lxd-agent-9p"), err)
}
Expand All @@ -235,7 +234,7 @@ start_pre() {
}
`

err = ioutil.WriteFile(filepath.Join(g.sourceDir, "/etc/init.d/lxd-agent-virtiofs"), []byte(lxdConfigShareMountVirtioFSScript), 0755)
err = os.WriteFile(filepath.Join(g.sourceDir, "/etc/init.d/lxd-agent-virtiofs"), []byte(lxdConfigShareMountVirtioFSScript), 0755)
if err != nil {
return fmt.Errorf("Failed to write file %q: %w", filepath.Join(g.sourceDir, "/etc/init.d/lxd-agent-virtiofs"), err)
}
Expand All @@ -260,7 +259,7 @@ respawn limit 10 5
exec lxd-agent
`

err := ioutil.WriteFile(filepath.Join(g.sourceDir, "/etc/init/lxd-agent"), []byte(lxdAgentScript), 0755)
err := os.WriteFile(filepath.Join(g.sourceDir, "/etc/init/lxd-agent"), []byte(lxdAgentScript), 0755)
if err != nil {
return fmt.Errorf("Failed to write file %q: %w", filepath.Join(g.sourceDir, "/etc/init/lxd-agent"), err)
}
Expand Down Expand Up @@ -289,7 +288,7 @@ task
exec mount -t 9p config /run/lxd_config/drive -o access=0,trans=virtio
`

err = ioutil.WriteFile(filepath.Join(g.sourceDir, "/etc/init/lxd-agent-9p"), []byte(lxdConfigShareMountScript), 0755)
err = os.WriteFile(filepath.Join(g.sourceDir, "/etc/init/lxd-agent-9p"), []byte(lxdConfigShareMountScript), 0755)
if err != nil {
return fmt.Errorf("Failed to write file %q: %w", filepath.Join(g.sourceDir, "/etc/init/lxd-agent-9p"), err)
}
Expand All @@ -313,7 +312,7 @@ task
exec mount -t virtiofs config /run/lxd_config/drive
`

err = ioutil.WriteFile(filepath.Join(g.sourceDir, "/etc/init/lxd-agent-virtiofs"), []byte(lxdConfigShareMountVirtioFSScript), 0755)
err = os.WriteFile(filepath.Join(g.sourceDir, "/etc/init/lxd-agent-virtiofs"), []byte(lxdConfigShareMountVirtioFSScript), 0755)
if err != nil {
return fmt.Errorf("Failed to write file %q: %w", filepath.Join(g.sourceDir, "/etc/init/lxd-agent-virtiofs"), err)
}
Expand Down
76 changes: 31 additions & 45 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -8,95 +8,81 @@ replace google.golang.org/grpc/naming => google.golang.org/grpc v1.29.1

require (
github.com/flosch/pongo2 v0.0.0-20200913210552-0d938eb266f3
github.com/gobuffalo/packr/v2 v2.8.3
github.com/lxc/lxd v0.0.0-20220330110539-f7a4698244cb
github.com/lxc/lxd v0.0.0-20220822084635-fbca37f4f4fc
github.com/mudler/docker-companion v0.4.6-0.20211015133729-bd4704fad372
github.com/sirupsen/logrus v1.8.1
github.com/spf13/cobra v1.4.0
github.com/stretchr/testify v1.7.1
golang.org/x/sys v0.0.0-20220330033206-e17cdc41300f
github.com/sirupsen/logrus v1.9.0
github.com/spf13/cobra v1.5.0
github.com/stretchr/testify v1.8.0
golang.org/x/sys v0.0.0-20220818161305-2296e01440c6
golang.org/x/text v0.3.7
gopkg.in/antchfx/htmlquery.v1 v1.2.2
gopkg.in/flosch/pongo2.v3 v3.0.0-20141028000813-5e81b817a0c4
gopkg.in/yaml.v2 v2.4.0
)

require (
github.com/AdaLogics/go-fuzz-headers v0.0.0-20220301192128-fe11a1f79e80 // indirect
github.com/AdaLogics/go-fuzz-headers v0.0.0-20220708163326-82d177caec6e // indirect
github.com/Azure/go-ansiterm v0.0.0-20210617225240-d185dfc1b5a1 // indirect
github.com/Microsoft/go-winio v0.5.2 // indirect
github.com/Microsoft/hcsshim v0.9.2 // indirect
github.com/antchfx/xpath v1.2.0 // indirect
github.com/Microsoft/hcsshim v0.9.4 // indirect
github.com/antchfx/xpath v1.2.1 // indirect
github.com/apex/log v1.9.0 // indirect
github.com/containerd/cgroups v1.0.3 // indirect
github.com/containerd/containerd v1.6.2 // indirect
github.com/containerd/continuity v0.2.2 // indirect
github.com/containerd/stargz-snapshotter/estargz v0.11.3 // indirect
github.com/cpuguy83/go-md2man/v2 v2.0.1 // indirect
github.com/containerd/cgroups v1.0.4 // indirect
github.com/containerd/containerd v1.6.8 // indirect
github.com/containerd/continuity v0.3.0 // indirect
github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect
github.com/cyphar/filepath-securejoin v0.2.3 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/docker/distribution v2.8.1+incompatible // indirect
github.com/docker/docker v20.10.14+incompatible // indirect
github.com/docker/docker v20.10.17+incompatible // indirect
github.com/docker/go-connections v0.4.0 // indirect
github.com/docker/go-units v0.4.0 // indirect
github.com/docker/libtrust v0.0.0-20160708172513-aabc10ec26b7 // indirect
github.com/fsouza/go-dockerclient v1.7.10 // indirect
github.com/fsouza/go-dockerclient v1.8.3 // indirect
github.com/go-macaroon-bakery/macaroonpb v1.0.0 // indirect
github.com/go-stack/stack v1.8.1 // indirect
github.com/gobuffalo/logger v1.0.6 // indirect
github.com/gobuffalo/packd v1.0.1 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.2 // indirect
github.com/google/go-containerregistry v0.8.0 // indirect
github.com/google/uuid v1.3.0 // indirect
github.com/gorilla/websocket v1.5.0 // indirect
github.com/heroku/docker-registry-client v0.0.0-20211012143308-9463674c8930 // indirect
github.com/inconshreveable/mousetrap v1.0.0 // indirect
github.com/inconshreveable/mousetrap v1.0.1 // indirect
github.com/juju/webbrowser v1.0.0 // indirect
github.com/julienschmidt/httprouter v1.3.0 // indirect
github.com/karrick/godirwalk v1.16.1 // indirect
github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 // indirect
github.com/klauspost/compress v1.15.1 // indirect
github.com/klauspost/compress v1.15.9 // indirect
github.com/klauspost/pgzip v1.2.5 // indirect
github.com/kr/fs v0.1.0 // indirect
github.com/markbates/errx v1.1.0 // indirect
github.com/markbates/oncer v1.0.0 // indirect
github.com/markbates/safe v1.0.1 // indirect
github.com/mattn/go-colorable v0.1.12 // indirect
github.com/mattn/go-isatty v0.0.14 // indirect
github.com/moby/sys/mount v0.3.1 // indirect
github.com/moby/sys/mountinfo v0.6.0 // indirect
github.com/moby/term v0.0.0-20210619224110-3f7ff695adc6 // indirect
github.com/moby/sys/mount v0.3.3 // indirect
github.com/moby/sys/mountinfo v0.6.2 // indirect
github.com/moby/term v0.0.0-20220808134915-39b0c02b01ae // indirect
github.com/morikuni/aec v1.0.0 // indirect
github.com/opencontainers/go-digest v1.0.0 // indirect
github.com/opencontainers/image-spec v1.0.2 // indirect
github.com/opencontainers/runc v1.1.1 // indirect
github.com/opencontainers/image-spec v1.0.3-0.20220114050600-8b9d41f48198 // indirect
github.com/opencontainers/runc v1.1.3 // indirect
github.com/opencontainers/runtime-spec v1.0.3-0.20210326190908-1c3f411f0417 // indirect
github.com/opencontainers/umoci v0.4.8-0.20211009121349-9c76304c034d // indirect
github.com/pborman/uuid v1.2.1 // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/pkg/sftp v1.13.4 // indirect
github.com/pkg/sftp v1.13.5 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/robfig/cron/v3 v3.0.1 // indirect
github.com/rogpeppe/fastuuid v1.2.0 // indirect
github.com/rootless-containers/proto/go-proto v0.0.0-20210921234734-69430b6543fb // indirect
github.com/russross/blackfriday/v2 v2.1.0 // indirect
github.com/spf13/jwalterweatherman v1.1.0 // indirect
github.com/spf13/pflag v1.0.5 // indirect
github.com/urfave/cli v1.22.5 // indirect
github.com/vbatts/go-mtree v0.5.0 // indirect
github.com/vbatts/tar-split v0.11.2 // indirect
github.com/urfave/cli v1.22.9 // indirect
github.com/vbatts/go-mtree v0.5.2 // indirect
go.opencensus.io v0.23.0 // indirect
golang.org/x/crypto v0.0.0-20220321153916-2c7772ba3064 // indirect
golang.org/x/net v0.0.0-20220325170049-de3da57026de // indirect
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c // indirect
golang.org/x/term v0.0.0-20210927222741-03fcf44c2211 // indirect
google.golang.org/protobuf v1.28.0 // indirect
golang.org/x/crypto v0.0.0-20220817201139-bc19a97f63c8 // indirect
golang.org/x/net v0.0.0-20220812174116-3211cb980234 // indirect
golang.org/x/sync v0.0.0-20220819030929-7fc1605a5dde // indirect
golang.org/x/term v0.0.0-20220722155259-a9ba230a4035 // indirect
google.golang.org/protobuf v1.28.1 // indirect
gopkg.in/errgo.v1 v1.0.1 // indirect
gopkg.in/httprequest.v1 v1.2.1 // indirect
gopkg.in/inconshreveable/log15.v2 v2.0.0-20200109203555-b30bc20e4fd1 // indirect
gopkg.in/macaroon-bakery.v2 v2.3.0 // indirect
gopkg.in/macaroon-bakery.v3 v3.0.0 // indirect
gopkg.in/macaroon.v2 v2.1.0 // indirect
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)
Loading