Headerbar support via plugin (discussion in #276) #614

lwindolf · 2018-03-07T20:11:17Z

No description provided.

The `gtk-apply` icon name is a legacy Gtk stock icon name and should be replaced.

…lbacks A single GAction that take a GVariant parameter replaces the multiple GtkRadioAction. It looks like radio menu items are created only with a parameter of type string.

…allbacks

Add the toolbar in its own ui file.

Adds functions in ui_common to enable or add to a map all actions of a group. Modifies functions that enable/disable actions.

Modifies plugin-installer to use builder.

instead of creating a GtkMenuBar widget. This way accelerators at least work.

It doesn't work with GAction.

With the accelerators set in the menu, it was possible to change them by calling `gtk_application_set_accels_for_action` but if an accelerator was already defined for an action the old one stayed displayed in the menu.

Leiaz

Currently this plugin needs to be deactivated with the "no plugin" option from the command line. You can merge #608 now (there may be bugs and custom accelerators don't work but it's not broken) if you want to add a few actions, and people could test both together.

Leiaz · 2018-03-08T21:11:51Z

plugins/headerbar.plugin

+Name=Header Bar
+Version=0.1
+Description=Get a GNOME style header bar for Liferea
+Authors=Mozbugbox <mozbugbox@yahoo.com.au>


Mozbugbox ? :)

Copy&Paste :-)

Leiaz · 2018-03-08T21:24:13Z

plugins/headerbar.py

+        ui_manager.get_widget("/MainwindowMenubar/").set_visible(True)
+        self.hb = None
+
+    def _on_back(self, button):


This won't be necessary. Buttons are GtkActionables and can be directly associated with an action.

Leiaz · 2018-03-08T21:34:37Z

plugins/headerbar.py

+
+        self.shell.lookup("mainwindow").set_titlebar(self.hb)
+
+        ui_manager = self.shell.get_property("ui-manager")


I changed the property name to "builder" in #608. (And maybe it doesn't need to be a property, as liferea_shell_lookup could be used).

I agree about not using ui_manager. Will rebase it once #608 is merged.

liferea_shell_lookup() cannot be used though (with GtkUIManager at least) as the widget names are not exposed.

Also resolved.

Leiaz · 2018-03-08T22:11:42Z

plugins/headerbar.py

+        ui_manager = self.shell.get_property("ui-manager")
+        ui_manager.get_widget("/maintoolbar/").set_visible(True)
+        ui_manager.get_widget("/MainwindowMenubar/").set_visible(True)
+        self.hb = None


The window likely takes ownership of the bar, so this won't remove it. Setting the window's titlebar to None should work.

Well it works. Setting to None might be problematic when reactivating.

Does the titlebar stay visible for you? If yes, which WM do you use?

Yes, the GtkHeaderBar stays. I use XMonad, but the same thing happens in a Debian 8 VM with Gnome.

Why would it be problematic ? A new GtkHeaderBar is created and set as titlebar in do_activate.

You are right. I changed the deactivate() behaviour to

self.shell.lookup("mainwindow").set_titlebar(None)

Update Turkish translation

I previously used the same user_data parameter as the gtk_action_group_add_actions calls but no callback actually uses that parameter.

Style suggested on the Gnome wiki : https://wiki.gnome.org/HowDoI/GAction

- fix the translation of the word “support”, thanks to external review - wrap to 80 characters

Update french translation

Modifies the ui_popup_item_menu function to build the menu with actions, and to apply to the clicked item. Changes the button press event handler to not change selection on right click. The item passed to `ui_popup_item_menu` will be destroyed after the function returns, it can't be directly passed to callbacks. Some actions use only a link and are identical to actions in the web view context menu. Those actions take the link as parameter and are added to the application to be accessible to both menus, this also makes them directly usable by plugins : - open-link-in-tab - open-link-browser - open-link-in-external-browser - social-bookmark-link - copy-link-to-clipboard Some actions require the item. In that case the actions take the item->id as a parameter. Those actions are added directly to the popup menu. The same callbacks are used for those actions and the actions that use the selected item. - copy-item-to-newsbin - toggle-item-flag - toggle-item-status - remove-item

Creates GActions that act on the node passed as a user-data parameter instead of the selected node. Uses the "new-" actions from the app, as making them insert new node relative to a passed node instead of the selected one would require more changes.

Switch to GAction and GtkBuilder

…into headerbar-plugin

lwindolf · 2018-04-10T21:32:22Z

So far I'd say the plugin is somewhat complete.

Leiaz · 2018-04-11T19:54:20Z

Yes, looks good. 👍

Lars Windolf and others added 20 commits January 29, 2018 22:45

Headerbar support via plugin (discussion in #276)

e7f18bf

Update Turkish translation

2f95dfe

Adds GActionEntry array for the AddActions and modifies callbacks

dae7af6

Adds ui file describing the menu

0eebece

The `gtk-apply` icon name is a legacy Gtk stock icon name and should be replaced.

Adds GActionEntry array for GeneralActions and modifies callbacks

85c6ba1

Adds GActionEntry for view mode choice and modifies corresponding cal…

01e4515

…lbacks A single GAction that take a GVariant parameter replaces the multiple GtkRadioAction. It looks like radio menu items are created only with a parameter of type string.

Adds GActionEntries for Fullscreen and ReducedFeedList and modifies c…

0a62130

…allbacks

Adds GActionEntry array for FeedActions and modifies callbacks

6b17caf

Adds GActionEntry array for ReadWriteActions and modifies callbacks

27997b7

Adds GActionEntry array for ItemActions and modifies callbacks

9631494

Adds all GActions to application

4092e9f

Replaces old menu and toolbar with new

2de5eef

Add the toolbar in its own ui file.

Adds new ui files to POTFILES.in

6a72498

Restores ReducedFeedList action state

91b71ae

Create actions in groups before adding them to app

8ca2b3c

Adds functions in ui_common to enable or add to a map all actions of a group. Modifies functions that enable/disable actions.

Removes unused GtkAction code

f4e9829

Replaces GtkUIManager by GtkBuilder

624fc21

Modifies plugin-installer to use builder.

Sets the menubar as application menubar

0df738a

instead of creating a GtkMenuBar widget. This way accelerators at least work.

Removes save/load accels map

28fce17

It doesn't work with GAction.

Moves accelerators from menu to liferea_shell.c

a5da84f

With the accelerators set in the menu, it was possible to change them by calling `gtk_application_set_accels_for_action` but if an accelerator was already defined for an action the old one stayed displayed in the menu.

lwindolf added the enhancement label Mar 7, 2018

lwindolf added this to the 1.12.3 milestone Mar 7, 2018

lwindolf self-assigned this Mar 7, 2018

lwindolf requested a review from Leiaz March 7, 2018 20:11

lwindolf mentioned this pull request Mar 7, 2018

Any plans to switch to GTK3 Header Bars? #176

Closed

Leiaz reviewed Mar 8, 2018

View reviewed changes

lwindolf added 3 commits March 10, 2018 12:24

Merge branch 'master' into headerbar-plugin

8c90131

Fix author

ed56dd7

#618 Ubuntu addition to the desktop file

7427535

lwindolf and others added 23 commits March 12, 2018 21:34

#618 Ubuntu addition to the desktop file

918925b

Merge branch 'master' into master

3ab0505

Update tr.po

c76d1bf

Merge pull request #600 from emintufan/master

a987c13

Update Turkish translation

Removes old unused systray code

c46f16d

Changes g_action_map_add_action_entries parameter

3ed7ff2

I previously used the same user_data parameter as the gtk_action_group_add_actions calls but no callback actually uses that parameter.

Changes action names to all lower case

559ff5b

Style suggested on the Gnome wiki : https://wiki.gnome.org/HowDoI/GAction

Update french translation

3938f82

- fix the translation of the word “support”, thanks to external review - wrap to 80 characters

Typo in action name

8e1ac74

Merge pull request #619 from guilieb/master

7dddc8f

Update french translation

Regarding #411: Add floating statusbar plugin to plugin manager.

47b7fd0

Fix missing module name.

6a75096

Merge pull request #608 from Leiaz/switch-to-gaction-and-gtkbuilder

c7f7409

Switch to GAction and GtkBuilder

Add ChangeLog for #608

24db29e

Update (c) and fix exception on pix=None

2262aeb

Fixes #625: Avoid exception in trayicon.py

db02786

Headerbar support via plugin (discussion in #276)

750848e

Fix author

fefed74

Switch to GAction. Connect all buttons except the menu button.

085a53c

Merge branch 'headerbar-plugin' of https://github.com/lwindolf/liferea …

1d3e017

…into headerbar-plugin

Connect menu button. Set titlebar None.

f0286c6

lwindolf merged commit 50078e8 into master Apr 11, 2018

lwindolf added a commit that referenced this pull request May 1, 2018

Adding missing Changelog for #634,#614,#591,#630,#619,#600

f6da573

lwindolf deleted the headerbar-plugin branch August 17, 2018 20:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Headerbar support via plugin (discussion in #276) #614

Headerbar support via plugin (discussion in #276) #614

lwindolf commented Mar 7, 2018

Leiaz left a comment

Leiaz Mar 8, 2018

lwindolf Mar 10, 2018

Leiaz Mar 8, 2018

lwindolf Apr 10, 2018

Leiaz Mar 8, 2018

lwindolf Mar 10, 2018

lwindolf Apr 10, 2018

Leiaz Mar 8, 2018

lwindolf Mar 10, 2018

Leiaz Mar 10, 2018

lwindolf Apr 10, 2018

lwindolf commented Apr 10, 2018

Leiaz commented Apr 11, 2018


		self.shell.lookup("mainwindow").set_titlebar(self.hb)

		ui_manager = self.shell.get_property("ui-manager")

Headerbar support via plugin (discussion in #276) #614

Headerbar support via plugin (discussion in #276) #614

Conversation

lwindolf commented Mar 7, 2018

Leiaz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lwindolf commented Apr 10, 2018

Leiaz commented Apr 11, 2018