Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent erroneous "Mark all as read" #32

Closed
Mno-hime opened this issue Jun 1, 2014 · 8 comments
Closed

Prevent erroneous "Mark all as read" #32

Mno-hime opened this issue Jun 1, 2014 · 8 comments

Comments

@Mno-hime
Copy link

Mno-hime commented Jun 1, 2014

I have a search folder for all unread items and the other day I erroneously marked it as read (hit Ctrl-R instead of Ctrl-U).. I'd lost the list if not having a yesterday's backup of Liferea's DB.

Can it be prevented in some way? Undo function would be nice but some non-intrusive confirmation dialogue would work for me as well.

@Mno-hime
Copy link
Author

Disabling Ctrl-R accelerator as per recent blog trick helped me a lot.

@gusnan
Copy link

gusnan commented Apr 12, 2015

I have the same problem, but when right-clicking the channel name and aim for Update Folder, I some times (too often) by mistake hit the "Mark All as Read" menu item just below. Either moving the "Mark All as read" item, or as Mno-hime mentioned, making a confirmation dialog on the "Mark all as read" item would solve the problem.

@lwindolf
Copy link
Owner

As a first solution I moved the menu option in the popup menu. Depending on the menu composition (as some items are optional according to the node type selected) the "Mark All Read" option is now in the middle. As in minimalistic menus (read-only sources) "Update" might still be above "Mark All Read" I additionally added a menu separator.

As for the hotkey I also fall victim for it from time to time.

I think I'll change Ctrl-R to refreshing the web view and assigning an entirely new accelerator for "Mark All as Read". I'm not yet sure which though...

@gusnan
Copy link

gusnan commented Apr 16, 2015

Excellent! - I just compiled the git version, and it looks like a good solution for my menu problems. Much appreciated!

@GreenLunar
Copy link
Collaborator

Related to #228

@voidplayer
Copy link

voidplayer commented Sep 6, 2016

today i clicked mark all as read instead of update feed... again...

(yes, i have minimal menu from read only sources with only those 2 options)

solutions that comes to mind:

  • Is it possible to change the color of the icon? both being green and both having some kind of pointy design does not help
  • some confirmation dialog would be great as well. How often do you want to mark all as read, anyway? once per session as maximum. It is not very tedious to do, and prevent you from doing one of the worst mistakes you can do related to feed reader
  • undo mark all as read. There is no need to implement some complete undo action for everything, only to remember the last state when you click mark all as read

Thanks for considering!

@dxwc
Copy link

dxwc commented Jan 5, 2018

Same here. Just accidentally clicked 'Mark Items as Read' on a large folder while trying to add a new subscription there. Don't know much C to add a patch for myself. Do consider this issue if possible for future updates/release.

(Version 1.12.0 on Solus 3.26.2)

@lwindolf
Copy link
Owner

lwindolf commented Mar 7, 2018

An update on this topic: The next release will have an confirmation dialog.

Closing this as a duplicate of the newer discussion in #591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants