-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs for booktabs
lib
#443
Conversation
5475e5c
to
4cd744c
Compare
I guess replacing "rb" and "wb" with "r' and "w" will solve eol problem among different operating systems, if we also modify local function ReadFile(input)
local f = io.open(input, "rb")
if f == nil then
print("Error in reading " .. input)
return
end
local text = f:read("*all")
f:close()
return text
end
local function WriteFile(output, text)
f = io.open(output, "wb")
f:write(text)
f:close()
end |
4cd744c
to
acaa2ec
Compare
I dropped patch to |
I'm not convinced. That example in tabularray/testfiles/table-010.tex Lines 21 to 27 in 54cceac
I agree that minimal and integrated test examples are both needed in some extent, so feel free to restore changes in |
Main changes
booktabs
table commandsbooktabs
packagel/r/lr
frombooktabs
lib section to the (general) hlines and vlines sectionWARNING
tabularray.tex
is not updated, due to EOL issue previously encountered and discussed in #385 (comment).Here I have to apply patch
to overcome lua error
thrown when executing
texlua manual.lua
. Even then, a Git warningis encountered.
tabularray
(and perhaps other open source repos by the same author) need a workflow to allow users on OS's using different EOL characters working together.