Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spq_select() behavior #203

Merged
merged 12 commits into from
Oct 19, 2023
Merged

fix: spq_select() behavior #203

merged 12 commits into from
Oct 19, 2023

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Oct 12, 2023

plus a bit of refactoring and better erroring

Fix #200

@maelle
fix: spq_select() behavior
4007511 
plus a bit of refactoring and better erroring
@maelle maelle requested a review from lvaudor October 12, 2023 11:12
@maelle maelle marked this pull request as draft October 12, 2023 11:17
@maelle
Copy link
Collaborator Author

maelle commented Oct 12, 2023

@lvaudor interestingly inside glitter I used spq_select() a lot to start tracking a variable as selected, so I had to replace these calls with calls to track_structure().

@maelle maelle marked this pull request as ready for review October 12, 2023 11:42
@maelle maelle mentioned this pull request Oct 12, 2023
Open
@maelle maelle merged commit f89f4c9 into main Oct 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvaudor lvaudor Awaiting requested review from lvaudor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spq_select works with negative selection, not positive
1 participant
@maelle