Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition UrlRule does not work on Hidden. #1146

Closed
nadar opened this issue Jan 10, 2017 · 0 comments
Closed

Composition UrlRule does not work on Hidden. #1146

nadar opened this issue Jan 10, 2017 · 0 comments
Assignees
@nadar
Labels
architecture bug
Milestone
1.0.0-rc3

Comments

@nadar
Copy link
Contributor

nadar commented Jan 10, 2017 •
edited
Loading

If the composition languageShortCode is not the default code but a composition url rule exists and the composition isHidden is true, the url creator (and parse) can not handel composition url rules.

When a page is provided by multiple domain and not the default language is provided via domain where those url rules are provided as composition rules, not found.
@nadar nadar added the bug label Jan 10, 2017
@nadar nadar self-assigned this Jan 10, 2017
nadar added a commit that referenced this issue Jan 10, 2017
@nadar
urlManager composition issue #1146
933a438
@nadar nadar added this to the 1.0.0 milestone Jan 11, 2017
nadar added a commit that referenced this issue Jan 11, 2017
@nadar
fixed url rule behavior when composition is hidden but an url rule is a
48fef6d 
composition rule. #1146
nadar added a commit that referenced this issue Jan 11, 2017
@nadar
fixed url creation for hidden language composition rules #1146
928eeaf
nadar added a commit that referenced this issue Jan 11, 2017
@nadar
merged temp fix into master #1146
4bdba36
@nadar nadar closed this as completed Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadar nadar

Labels
architecture bug
Projects
None yet
Milestone
1.0.0-rc3
Development

No branches or pull requests
1 participant
@nadar