Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Link Object Interface in order to unify external and internal links. #1081

Closed
nadar opened this issue Nov 16, 2016 · 1 comment
Closed

Add Link Object Interface in order to unify external and internal links. #1081

nadar opened this issue Nov 16, 2016 · 1 comment
Assignees
@nadar
Labels
enhancement
Milestone
1.0.0-rc2

Comments

@nadar
Copy link
Contributor

nadar commented Nov 16, 2016

An internface which can be implement for linkabel class with getSource and getIsExternal methods.
nadar added a commit that referenced this issue Nov 16, 2016
@nadar
Linkable object example #1081
646beb8
@nadar nadar added this to the 1.0.0-rc2 milestone Nov 22, 2016
@nadar nadar self-assigned this Nov 22, 2016
nadar added a commit that referenced this issue Nov 22, 2016
@nadar
Generate Link Interface for internal and external links in order to
0624523 
identify different link types. #1081
@nadar
Copy link
Contributor Author

nadar commented Nov 25, 2016 •
edited
Loading

changed getTarget to _blank when menu item is redirect.

(maybe not an expected behavior)

@nadar nadar closed this as completed Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadar nadar

Labels
enhancement
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
1 participant
@nadar