Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BC BREAK][CMS BLOCKS] consistency renaming of BlockInterface methods. #1070

Closed
nadar opened this issue Nov 1, 2016 · 0 comments
Closed

[BC BREAK][CMS BLOCKS] consistency renaming of BlockInterface methods. #1070

nadar opened this issue Nov 1, 2016 · 0 comments
Assignees
@nadar
Labels
architecture
Milestone
1.0.0-rc2

Comments

@nadar
Copy link
Contributor

nadar commented Nov 1, 2016 •
edited
Loading

Rename following methods of luya\cms\base\InternalBaseBlock:

Old New
getBlockGroup() blockGroup()
extraVarsOutput() getExtraVarValues()
getVars() getConfigVarsExport()
getCfgs() getConfigCfgsExport()
getPlaceholders() getConfigPlaceholdersExport()

Remove:

getFullName()
getAssets()
@nadar nadar added this to the 1.0.0-rc2 milestone Nov 1, 2016
@nadar nadar self-assigned this Nov 1, 2016
@nadar nadar changed the title [BC BREAK][CMS BLOCKS] Consistenc renaming of BlockInterface methods. [BC BREAK][CMS BLOCKS] consistency renaming of BlockInterface methods. Nov 1, 2016
@nadar nadar closed this as completed in e845d7b Nov 1, 2016
nadar added a commit that referenced this issue Nov 1, 2016
@nadar
fixed renaming #1070
724cc9c
nadar added a commit that referenced this issue Nov 1, 2016
@nadar
change methods names for consistency #1070
646a81d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadar nadar

Labels
architecture
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
1 participant
@nadar