SevenZipSharp.Interop.NoReferences: fix naming of targets file for importing to work #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuGet will only import `.targets` file from a package if its name matches the package name.
|
Thanks for your PR, I'll publish a new version |
|
I've just published the new version to nuget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By convention NuGet will only import
.targetsfile from a package if its name matches the package id.Previously, for package
SevenZipSharp.Interop.NoReferencesthe.targetsfile name wasSevenZipSharp.Interop.targets, which resulted in NuGet not importing it, and as a result 7z.dll weren't copied to the output folder.This fixes it by copying the
.targetsfile with a correct name. Unfortunately I had to explicitly list all copied files in the.nuspecbut I think it's acceptable.I verified this fix locally, now the binaries get copied to the output folder.