Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated wiki parsers #66

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Updated wiki parsers #66

merged 5 commits into from
Jan 22, 2025

Conversation

luttje
Copy link
Owner

@luttje luttje commented Jan 22, 2025

No description provided.

@luttje luttje added the enhancement New feature or request label Jan 22, 2025
@luttje luttje self-assigned this Jan 22, 2025
@luttje luttje linked an issue Jan 22, 2025 that may be closed by this pull request
6 tasks
@luttje
Copy link
Owner Author

luttje commented Jan 22, 2025

Until LuaLS/lua-language-server#2721 is implemented enums in LuaLS can only be defined as a table.

Currently we use @alias to strongly type global enumerations. However looking at how this suggests values, I think it'll lead developers into bad habbits:
Image

@luttje luttje marked this pull request as ready for review January 22, 2025 11:03
@luttje luttje mentioned this pull request Jan 22, 2025
6 tasks
@luttje luttje merged commit d5d9a0e into main Jan 22, 2025
2 checks passed
@luttje luttje deleted the feature/updated-wiki-parsers branch January 22, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some improvement ideas for the future
1 participant