Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support key binds mapping #21

Merged
merged 16 commits into from
Aug 9, 2024
Merged

Conversation

yanganto
Copy link
Contributor

@yanganto yanganto commented Aug 1, 2024

fix #15

@yanganto yanganto marked this pull request as ready for review August 4, 2024 06:34
@yanganto yanganto mentioned this pull request Aug 4, 2024
5 tasks
@lusingander
Copy link
Owner

Thank you, I'm checking

Copy link
Owner

@lusingander lusingander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for responding!

  • To address some of the issues with event handling, we may be able to make handle_user_event something like handle_event(UserEvent, KeyEvent) and leave it up to each View or Widget like in the original implementation rather than managing insert_mode on the App.

flake.nix Outdated Show resolved Hide resolved
assets/default-keybind.toml Outdated Show resolved Hide resolved
assets/default-keybind.toml Outdated Show resolved Hide resolved
assets/default-keybind.toml Outdated Show resolved Hide resolved
src/app.rs Outdated Show resolved Hide resolved
src/app.rs Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
src/keybind.rs Outdated Show resolved Hide resolved
src/keybind.rs Outdated Show resolved Hide resolved
src/keybind.rs Outdated Show resolved Hide resolved
@yanganto yanganto requested a review from lusingander August 8, 2024 06:53
Copy link
Owner

@lusingander lusingander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction, I added some comments.

src/config.rs Outdated Show resolved Hide resolved
src/keybind.rs Outdated Show resolved Hide resolved
src/app.rs Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@yanganto yanganto requested a review from lusingander August 9, 2024 06:09
@yanganto
Copy link
Contributor Author

yanganto commented Aug 9, 2024

Hi @lusingander,
Thanks for the review. Now everything is good to go.

@lusingander
Copy link
Owner

Thanks so much, please check only the ci error? (I think it's a missed fix in the test code)

@lusingander
Copy link
Owner

Great!!

@lusingander lusingander merged commit db1db65 into lusingander:master Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support key binds mapping
2 participants