-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support key binds mapping #21
Conversation
Thank you, I'm checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for responding!
- To address some of the issues with event handling, we may be able to make
handle_user_event
something likehandle_event(UserEvent, KeyEvent)
and leave it up to each View or Widget like in the original implementation rather than managinginsert_mode
on the App.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the correction, I added some comments.
Hi @lusingander, |
Thanks so much, please check only the ci error? (I think it's a missed fix in the test code) |
Great!! |
fix #15