Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web deploy prerequisites #1851
Web deploy prerequisites #1851
Changes from 16 commits
016018e
d3848ed
7b2b801
46f4f20
64c81d8
d64e66e
967ffb1
1edf21d
ac5e061
36f4120
27b8aa7
1b67222
95c9c0b
f5ce8e7
1026a0c
0a7feb4
05a2cd1
56bc3fd
753fd41
7cc72f8
feaaca6
6c0cba7
4a2bbcc
350162d
5ddd0de
7afb09d
f8e549c
3add0a3
ad0e32d
f4a7d6e
6de0f30
66cf411
f81241e
ce35078
db13411
15245af
c5cf5d5
2177370
08e998e
08496c8
a72e9cb
8023c9e
fb97647
a474d0d
f01e1b9
65364ee
ef6904c
303282a
7ffa670
ffa9e31
3925acc
a41e20d
e4215d4
82d34dc
5a99626
9a0d2a6
be42509
09c8d76
d45f655
163bbcf
0b87b33
081e394
70feb28
32d91e2
200f406
ea4d09e
88f6b4a
5bb6b87
bb6bd6c
24ff2c4
386e076
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to include
.aws
files? @cosmos/sre ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are used by the current (temporary) node setup on EC2, until the real network boot on merge is ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in theory we could have a second gaiacli instance where we import the main key which performs the action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct! @mircea-c told me something like this will become true in their infrastructure + stargate will be on a separate machine, so for now I left the hacky solution, but I'll add a TODO to remember that when we'll adopt the real network deployment this PID stuff has to be removed, sounds ok?