Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/1821 improve testnet and output #1829

Merged
merged 7 commits into from
Jan 16, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Jan 14, 2019

Closes #1821, #1760, #1761
Also fixed issue with more then 2 nodes
Renamed accounts to be more self explaining

Based on Voyager Web PR

Description:

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@faboweb faboweb changed the title Fabo/improve testnet and output Fabo/1821 improve testnet and output Jan 14, 2019
@fedekunze
Copy link
Contributor

shouldn't this be rebased to the web PR ?

@faboweb faboweb changed the base branch from develop to fabo/voyager-web January 15, 2019 17:19
fedekunze and others added 2 commits January 16, 2019 10:50
Co-Authored-By: faboweb <frznhope@gmail.com>
Co-Authored-By: faboweb <frznhope@gmail.com>
@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #1829 into fabo/voyager-web will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           fabo/voyager-web    #1829   +/-   ##
=================================================
  Coverage             93.56%   93.56%           
=================================================
  Files                   116      116           
  Lines                  2517     2517           
  Branches                118      118           
=================================================
  Hits                   2355     2355           
  Misses                  153      153           
  Partials                  9        9

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@fedekunze fedekunze merged commit 4cd9346 into fabo/voyager-web Jan 16, 2019
@fedekunze fedekunze deleted the fabo/improve-testnet-and-output branch January 16, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants