fedekunze/1769 remove hardcoded params #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 19, 2018 13:05
…/voyager into fedekunze/1769-rm-hardcoded-params Merge changes from amount PR branch
added 10 commits
December 20, 2018 21:47
Codecov Report
@@ Coverage Diff @@
## develop #1770 +/- ##
===========================================
+ Coverage 95.07% 95.07% +<.01%
===========================================
Files 122 122
Lines 2982 2987 +5
Branches 128 128
===========================================
+ Hits 2835 2840 +5
Misses 137 137
Partials 10 10
|
Codecov Report
@@ Coverage Diff @@
## develop #1770 +/- ##
===========================================
+ Coverage 94.85% 94.86% +<.01%
===========================================
Files 123 123
Lines 2953 2958 +5
Branches 121 121
===========================================
+ Hits 2801 2806 +5
Misses 143 143
Partials 9 9
|
fedekunze
changed the title
fedekunze
changed the title
…om/cosmos/voyager into fedekunze/1769-rm-hardcoded-params fix conflict
fedekunze
changed the title
faboweb
reviewed
Jan 4, 2019
faboweb
reviewed
Jan 4, 2019
test/unit/specs/components/wallet/__snapshots__/PageSend.spec.js.snap
Outdated
Show resolved
Hide resolved
sabau
reviewed
Jan 4, 2019
test/unit/specs/components/wallet/__snapshots__/PageSend.spec.js.snap
Outdated
Show resolved
Hide resolved
sabau
reviewed
Jan 4, 2019
jbibla
reviewed
Jan 4, 2019
faboweb
reviewed
Jan 7, 2019
test/unit/specs/components/staking/__snapshots__/PageValidator.spec.js.snap
Outdated
Show resolved
Hide resolved
faboweb
reviewed
Jan 8, 2019
| @@ -3493,7 +3493,7 @@ exports[`onDelegation onUnstake make sure there are enough atoms to unstake is n | |||
| </div> | |||
| `; | |||
|
|
|||
| exports[`onDelegation onUnstake submitUndelegation composition delegation.submitDelegation 1`] = ` | |||
| exports[`onDelegation onUnstake submitUndelegation composition submits a successful undelegation 1`] = ` | |||
There was a problem hiding this comment.
I like the phrase like description a lot more. 👍
faboweb
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1769
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer