Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/1433 migrate to latest sdk #1450

Merged
merged 28 commits into from
Oct 18, 2018
Merged

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Oct 10, 2018

Closes #1433, #1428

Description:

  • fix e2e setup
  • handle decimal tokens

❤️ Thank you!

@faboweb faboweb changed the title WIP: Fabo/1433 migrate to latest sdk Fabo/1433 migrate to latest sdk Oct 16, 2018
@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #1450 into develop will decrease coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1450      +/-   ##
===========================================
- Coverage    96.76%   96.73%   -0.04%     
===========================================
  Files           89       89              
  Lines         1702     1682      -20     
  Branches        80       77       -3     
===========================================
- Hits          1647     1627      -20     
  Misses          45       45              
  Partials        10       10
Impacted Files Coverage Δ
app/src/renderer/components/wallet/PageSend.vue 100% <ø> (ø) ⬆️
app/src/renderer/main.js 92.68% <ø> (+0.18%) ⬆️
tasks/createReleasePR.js 61.11% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/send.js 100% <100%> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 98.8% <100%> (+0.02%) ⬆️
...pp/src/renderer/components/staking/PageStaking.vue 100% <100%> (ø) ⬆️
app/src/renderer/vuex/store.js 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/user.js 100% <100%> (ø) ⬆️
.../src/renderer/components/staking/TabValidators.vue 95% <100%> (-0.13%) ⬇️
app/src/renderer/connectors/lcdClient.js 90.62% <100%> (ø) ⬆️
... and 6 more

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 16, 2018

Follow up: #1473

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 17, 2018

Building inside docker currently is not possible. You have to build the SDK by hand and copy the binaries to the respective places builds/Gaia/darwin_amd64.

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 17, 2018

Our full node is not on the lastest version and therefor Voyager will not work the standard way. I will ping Greg immediately after this PR is merged.

While this is the case, please run a local-testnet using LCD_URL=http://localhost:9070 RPC_URL=http://localhost:26657 yarn start local-testnet.

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but otherwise LGTM

@@ -158,7 +158,7 @@ exports[`PageValidator has the expected html structure 1`] = `
class="address"
id="address"
>
cosmoschiapudding…6789
…2b3c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test test uses some funky non-address value 1a2b3c. I will change this later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, we should consider refactoring all the unit tests to use only the mocked values from lcdClientMock to avoid changing so many files when there's a breaking change renaming on the SDK

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit 1047a7e into develop Oct 18, 2018
@fedekunze fedekunze deleted the fabo/1433-migrate-to-latest-sdk branch October 18, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to latest SDK develop
2 participants