-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabo/1433 migrate to latest sdk #1450
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1450 +/- ##
===========================================
- Coverage 96.76% 96.73% -0.04%
===========================================
Files 89 89
Lines 1702 1682 -20
Branches 80 77 -3
===========================================
- Hits 1647 1627 -20
Misses 45 45
Partials 10 10
|
Follow up: #1473 |
Building inside docker currently is not possible. You have to build the SDK by hand and copy the binaries to the respective places |
Our full node is not on the lastest version and therefor Voyager will not work the standard way. I will ping Greg immediately after this PR is merged. While this is the case, please run a local-testnet using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but otherwise LGTM
@@ -158,7 +158,7 @@ exports[`PageValidator has the expected html structure 1`] = ` | |||
class="address" | |||
id="address" | |||
> | |||
cosmoschiapudding…6789 | |||
…2b3c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test test uses some funky non-address value 1a2b3c
. I will change this later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, we should consider refactoring all the unit tests to use only the mocked values from lcdClientMock
to avoid changing so many files when there's a breaking change renaming on the SDK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Closes #1433, #1428
Description:
❤️ Thank you!