Fix Setext headings in block quotes #471
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #465 (spoiler alert: I've introduced another problem).
I've added a new test that makes sure that this markdown
is parsed as a block quote containing a
h2
. I made the test pass but introduced another regression around lazy continuations of block quotes. This is quite a head-scratcher for me so I'm getting this out with the failing test, maybe we can start discussing intermediate results and another pair of eyes helps fixing the remaining regression (or making sense of my overall approach)