Handle errors about third party download and extract #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If absolute fail to download node binary, shell script should stop and print right error log. This patch do it. Additional add one function to print red color error log. ISSUE=none
|
@cs-lee, LGTM. Would you share how to fallback to error 2 or 3 cases? |
|
case 2 :
case 3 :
|
Add default color tag. ISSUE=none
extract function return error number when invalid input is comming. ISSUE=none
download and extract function handle error log itself. ISSUE=none
|
@romandev I applied your review comments. Please review. |
Change already sync error number. ISSUE=none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If script fail to download node binary, it should stop
and print right error log. This patch do it.
Additionally this patch add one function to print red color error log.
ISSUE=none