Skip to content

Commit

Permalink
Se cambian if else por switch.
Browse files Browse the repository at this point in the history
  • Loading branch information
@JuanGamezSW
JuanGamezSW committed Sep 24, 2018
1 parent 3d0c923 commit e723cb1
Show file tree
Hide file tree
Showing 3 changed files with 59 additions and 139 deletions.
128 changes: 38 additions & 90 deletions src/main/java/Utils/Requests/Issue/IssueRequest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,63 +51,36 @@ public IResponse sendRequest(IRequest request) throws GeneralException, AuthExce
if(status==200){
JSONObject data = body.getJSONObject("data");

if (request.version.equalsIgnoreCase("v1")) {
return new SuccessV1Response(status,body.getString("status"),data.getString("tfd"),"OK","OK");
switch(request.version) {
case "v1": return new SuccessV1Response(status,body.getString("status"),data.getString("tfd"),"OK","OK");
case "v2": return new SuccessV2Response(status,body.getString("status"),data.getString("tfd"),data.getString("cfdi"),"OK","OK");
case "v3": return new SuccessV3Response(status,body.getString("status"),data.getString("cfdi"),"OK","OK");
case "v4": return new SuccessV4Response(status,body.getString("status"),data.getString("cfdi"),data.getString("cadenaOriginalSAT"),data.getString("noCertificadoSAT"),data.getString("noCertificadoCFDI"),data.getString("uuid"),data.getString("selloSAT"),data.getString("selloCFDI"),data.getString("fechaTimbrado"),data.getString("qrCode"),"OK","OK");
default: return new SuccessV1Response(status,body.getString("status"),data.toString(),"OK","OK");
}
else if(request.version.equalsIgnoreCase("v2")){
return new SuccessV2Response(status,body.getString("status"),data.getString("tfd"),data.getString("cfdi"),"OK","OK");
}
else if(request.version.equalsIgnoreCase("v3")){
return new SuccessV3Response(status,body.getString("status"),data.getString("cfdi"),"OK","OK");

}else if(request.version.equalsIgnoreCase("v4")){
return new SuccessV4Response(status,body.getString("status"),data.getString("cfdi"),data.getString("cadenaOriginalSAT"),data.getString("noCertificadoSAT"),data.getString("noCertificadoCFDI"),data.getString("uuid"),data.getString("selloSAT"),data.getString("selloCFDI"),data.getString("fechaTimbrado"),data.getString("qrCode"),"OK","OK");
}
else{
return new SuccessV1Response(status,body.getString("status"),data.toString(),"OK","OK");
}


}
else{
String messageDetail = "";
if (!body.isNull("messageDetail")){
messageDetail = body.getString("messageDetail");
}
if (request.version.equalsIgnoreCase("v1")) {
return new SuccessV1Response(status,body.getString("status"),"",body.getString("message"),messageDetail);
}
else if(request.version.equalsIgnoreCase("v2")){
return new SuccessV2Response(status,body.getString("status"),"","",body.getString("message"),messageDetail);
}
else if(request.version.equalsIgnoreCase("v3")){
return new SuccessV3Response(status,body.getString("status"),"",body.getString("message"),messageDetail);

}else if(request.version.equalsIgnoreCase("v4")){
return new SuccessV4Response(status,body.getString("status"),"","","","","","","","","",body.getString("message"),messageDetail);
}
else{
return new SuccessV1Response(status,body.getString("status"),"",body.getString("message"),messageDetail);
switch(request.version) {
case "v1": return new SuccessV1Response(status,body.getString("status"),"",body.getString("message"),messageDetail);
case "v2": return new SuccessV2Response(status,body.getString("status"),"","",body.getString("message"),messageDetail);
case "v3": return new SuccessV3Response(status,body.getString("status"),"",body.getString("message"),messageDetail);
case "v4": return new SuccessV4Response(status,body.getString("status"),"","","","","","","","","",body.getString("message"),messageDetail);
default: return new SuccessV1Response(status,body.getString("status"),"",body.getString("message"),messageDetail);
}

}
}
else{
if (request.version.equalsIgnoreCase("v1")) {
return new SuccessV1Response(status,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
else if(request.version.equalsIgnoreCase("v2")){
return new SuccessV2Response(status,"error","","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
else if(request.version.equalsIgnoreCase("v3")){
return new SuccessV3Response(status,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());

}else if(request.version.equalsIgnoreCase("v4")){
return new SuccessV4Response(status,"error","","","","","","","","","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
else{
return new SuccessV1Response(status,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
switch(request.version) {
case "v1": return new SuccessV1Response(status,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
case "v2": return new SuccessV2Response(status,"error","","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
case "v3": return new SuccessV3Response(status,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
case "v4": return new SuccessV4Response(status,"error","","","","","","","","","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
default: return new SuccessV1Response(status,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
}

}
Expand Down Expand Up @@ -148,63 +121,38 @@ public IResponse sendRequestXml(IRequest request) throws GeneralException, AuthE
if(statusE==200){
JSONObject data = body.getJSONObject("data");

if (request.version.equalsIgnoreCase("v1")) {
return new SuccessV1Response(statusE,body.getString("status"),data.getString("tfd"),"OK","OK");
}
else if(request.version.equalsIgnoreCase("v2")){
return new SuccessV2Response(statusE,body.getString("status"),data.getString("tfd"),data.getString("cfdi"),"OK","OK");
}
else if(request.version.equalsIgnoreCase("v3")){
return new SuccessV3Response(statusE,body.getString("status"),data.getString("cfdi"),"OK","OK");

}else if(request.version.equalsIgnoreCase("v4")){
return new SuccessV4Response(statusE,body.getString("status"),data.getString("cfdi"),data.getString("cadenaOriginalSAT"),data.getString("noCertificadoSAT"),data.getString("noCertificadoCFDI"),data.getString("uuid"),data.getString("selloSAT"),data.getString("selloCFDI"),data.getString("fechaTimbrado"),data.getString("qrCode"),"OK","OK");
switch(request.version) {
case "v1": return new SuccessV1Response(statusE,body.getString("status"),data.getString("tfd"),"OK","OK");
case "v2": return new SuccessV2Response(statusE,body.getString("status"),data.getString("tfd"),data.getString("cfdi"),"OK","OK");
case "v3": return new SuccessV3Response(statusE,body.getString("status"),data.getString("cfdi"),"OK","OK");
case "v4": return new SuccessV4Response(statusE,body.getString("status"),data.getString("cfdi"),data.getString("cadenaOriginalSAT"),data.getString("noCertificadoSAT"),data.getString("noCertificadoCFDI"),data.getString("uuid"),data.getString("selloSAT"),data.getString("selloCFDI"),data.getString("fechaTimbrado"),data.getString("qrCode"),"OK","OK");
default: return new SuccessV1Response(statusE,body.getString("status"),data.toString(),"OK","OK");
}
else{
return new SuccessV1Response(statusE,body.getString("status"),data.toString(),"OK","OK");
}


}
else{
String messageDetail = "";
if (!body.isNull("messageDetail")){
messageDetail = body.getString("messageDetail");
}
if (request.version.equalsIgnoreCase("v1")) {
return new SuccessV1Response(statusE,body.getString("status"),"",body.getString("message"),messageDetail);
}
else if(request.version.equalsIgnoreCase("v2")){
return new SuccessV2Response(statusE,body.getString("status"),"","",body.getString("message"),messageDetail);
}
else if(request.version.equalsIgnoreCase("v3")){
return new SuccessV3Response(statusE,body.getString("status"),"",body.getString("message"),messageDetail);

}else if(request.version.equalsIgnoreCase("v4")){
return new SuccessV4Response(statusE,body.getString("status"),"","","","","","","","","",body.getString("message"),messageDetail);
}
else{
return new SuccessV1Response(statusE,body.getString("status"),"",body.getString("message"),messageDetail);
switch(request.version) {
case "v1": return new SuccessV1Response(statusE,body.getString("status"),"",body.getString("message"),messageDetail);
case "v2": return new SuccessV2Response(statusE,body.getString("status"),"","",body.getString("message"),messageDetail);
case "v3": return new SuccessV3Response(statusE,body.getString("status"),"",body.getString("message"),messageDetail);
case "v4": return new SuccessV4Response(statusE,body.getString("status"),"","","","","","","","","",body.getString("message"),messageDetail);
default: return new SuccessV1Response(statusE,body.getString("status"),"",body.getString("message"),messageDetail);
}

}
}
else{
if (request.version.equalsIgnoreCase("v1")) {
return new SuccessV1Response(statusE,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
else if(request.version.equalsIgnoreCase("v2")){
return new SuccessV2Response(statusE,"error","","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
else if(request.version.equalsIgnoreCase("v3")){
return new SuccessV3Response(statusE,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());

}else if(request.version.equalsIgnoreCase("v4")){
return new SuccessV4Response(statusE,"error","","","","","","","","","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
else{
return new SuccessV1Response(statusE,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
switch(request.version) {
case "v1": return new SuccessV1Response(statusE,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
case "v2": return new SuccessV2Response(statusE,"error","","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
case "v3": return new SuccessV3Response(statusE,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
case "v4": return new SuccessV4Response(statusE,"error","","","","","","","","","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
default: return new SuccessV1Response(statusE,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
}
}
catch (JSONException e){
Expand Down
66 changes: 19 additions & 47 deletions src/main/java/Utils/Requests/Stamp/StampRequest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,64 +56,36 @@ public IResponse sendRequest(IRequest request) throws GeneralException, AuthExce
JSONObject body = new JSONObject(responseString);
if(statusE==200){
JSONObject data = body.getJSONObject("data");

if (request.version.equalsIgnoreCase("v1")) {
return new SuccessV1Response(statusE,body.getString("status"),data.getString("tfd"),"OK","OK");
}
else if(request.version.equalsIgnoreCase("v2")){
return new SuccessV2Response(statusE,body.getString("status"),data.getString("tfd"),data.getString("cfdi"),"OK","OK");
}
else if(request.version.equalsIgnoreCase("v3")){
return new SuccessV3Response(statusE,body.getString("status"),data.getString("cfdi"),"OK","OK");

}else if(request.version.equalsIgnoreCase("v4")){
return new SuccessV4Response(statusE,body.getString("status"),data.getString("cfdi"),data.getString("cadenaOriginalSAT"),data.getString("noCertificadoSAT"),data.getString("noCertificadoCFDI"),data.getString("uuid"),data.getString("selloSAT"),data.getString("selloCFDI"),data.getString("fechaTimbrado"),data.getString("qrCode"),"OK","OK");
}
else{
return new SuccessV1Response(statusE,body.getString("status"),data.toString(),"OK","OK");
switch(request.version) {
case "v1": return new SuccessV1Response(statusE,body.getString("status"),data.getString("tfd"),"OK","OK");
case "v2": return new SuccessV2Response(statusE,body.getString("status"),data.getString("tfd"),data.getString("cfdi"),"OK","OK");
case "v3": return new SuccessV3Response(statusE,body.getString("status"),data.getString("cfdi"),"OK","OK");
case "v4": return new SuccessV4Response(statusE,body.getString("status"),data.getString("cfdi"),data.getString("cadenaOriginalSAT"),data.getString("noCertificadoSAT"),data.getString("noCertificadoCFDI"),data.getString("uuid"),data.getString("selloSAT"),data.getString("selloCFDI"),data.getString("fechaTimbrado"),data.getString("qrCode"),"OK","OK");
default: return new SuccessV1Response(statusE,body.getString("status"),data.toString(),"OK","OK");
}


}
else{
String messageDetail = "";
if (!body.isNull("messageDetail")){
messageDetail = body.getString("messageDetail");
}
if (request.version.equalsIgnoreCase("v1")) {
return new SuccessV1Response(statusE,body.getString("status"),"",body.getString("message"),messageDetail);
}
else if(request.version.equalsIgnoreCase("v2")){
return new SuccessV2Response(statusE,body.getString("status"),"","",body.getString("message"),messageDetail);
}
else if(request.version.equalsIgnoreCase("v3")){
return new SuccessV3Response(statusE,body.getString("status"),"",body.getString("message"),messageDetail);

}else if(request.version.equalsIgnoreCase("v4")){
return new SuccessV4Response(statusE,body.getString("status"),"","","","","","","","","",body.getString("message"),messageDetail);
}
else{
return new SuccessV1Response(statusE,body.getString("status"),"",body.getString("message"),messageDetail);
switch(request.version) {
case "v1": return new SuccessV1Response(statusE,body.getString("status"),"",body.getString("message"),messageDetail);
case "v2": return new SuccessV2Response(statusE,body.getString("status"),"","",body.getString("message"),messageDetail);
case "v3": return new SuccessV3Response(statusE,body.getString("status"),"",body.getString("message"),messageDetail);
case "v4": return new SuccessV4Response(statusE,body.getString("status"),"","","","","","","","","",body.getString("message"),messageDetail);
default: return new SuccessV1Response(statusE,body.getString("status"),"",body.getString("message"),messageDetail);
}

}
}
else{
if (request.version.equalsIgnoreCase("v1")) {
return new SuccessV1Response(statusE,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
else if(request.version.equalsIgnoreCase("v2")){
return new SuccessV2Response(statusE,"error","","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
else if(request.version.equalsIgnoreCase("v3")){
return new SuccessV3Response(statusE,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());

}else if(request.version.equalsIgnoreCase("v4")){
return new SuccessV4Response(statusE,"error","","","","","","","","","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
else{
return new SuccessV1Response(statusE,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
switch(request.version) {
case "v1": return new SuccessV1Response(statusE,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
case "v2": return new SuccessV2Response(statusE,"error","","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
case "v3": return new SuccessV3Response(statusE,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
case "v4": return new SuccessV4Response(statusE,"error","","","","","","","","","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
default: return new SuccessV1Response(statusE,"error","",responseB.getStatusLine().getReasonPhrase(),responseB.getStatusLine().getReasonPhrase());
}
}

}
Expand Down
Loading

0 comments on commit e723cb1

Please sign in to comment.