Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feacture/resend email #94

Merged
merged 20 commits into from
Nov 28, 2022
Merged

Feacture/resend email #94

merged 20 commits into from
Nov 28, 2022

Conversation

FerCarrilloM
Copy link
Contributor

No description provided.

FerCarrilloM and others added 8 commits November 23, 2022 13:43
-Se crean instancias publicas de la clase Resend
-Se crea la clase Resend
-Se crea la clase Request
-Se crea la clase Response
-Se crea la clase ResponseHandler
-Se crea la clase Response.
-Se crea la clase Request
-Se crea la clase ResponseHandler
-Se crea la clase BaseResend y Resend Service con sus respectivos metodos.
Se agrega una sección referente al método de Reenviar Email.
Copy link
Contributor

@martinfnsw martinfnsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo veo bien, falta actualizar la versión.

Copy link
Collaborator

@SwAeyrton SwAeyrton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Con la finalidad de acostumbrarnos a las buenas practicas, te sugiero corregir el nombre de la rama.

-Se agregan asserts faltantes
-Se corrige el namespaces
@FerCarrilloM FerCarrilloM merged commit fb97783 into develop Nov 28, 2022
@FerCarrilloM FerCarrilloM deleted the feacture/ResendEmail branch November 28, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants