Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update files #124

Merged
merged 26 commits into from
Aug 23, 2023
Merged

Feature/update files #124

merged 26 commits into from
Aug 23, 2023

Conversation

marifersw
Copy link
Contributor

No description provided.

SwAeyrton
SwAeyrton requested changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@SwAeyrton SwAeyrton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo ideal para los nombres de los resources, es usar nombres cortos, no es necesario mantener el nombre original de los certirficados.
Las UT fallan, los resources no estan agregados correctamente.

@marifersw marifersw requested a review from SwAeyrton August 22, 2023 23:49
martinfnsw
martinfnsw requested changes Aug 23, 2023
View reviewed changes
@marifersw marifersw merged commit 949b99d into develop Aug 23, 2023
@marifersw marifersw deleted the feature/updateFiles branch August 28, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwAeyrton SwAeyrton SwAeyrton approved these changes

@martinfnsw martinfnsw martinfnsw approved these changes

@ReyesSW ReyesSW ReyesSW approved these changes

@FerCarrilloM FerCarrilloM FerCarrilloM approved these changes

@SebastianSW SebastianSW SebastianSW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marifersw @SwAeyrton @martinfnsw @ReyesSW @FerCarrilloM @SebastianSW