[0.2] Hotfix - Discount issues #847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alecritson
approved these changes
Feb 10, 2023
glennjacobs
approved these changes
Feb 10, 2023
|
@ryanmitchell Looks like there's some conflicts since the other PR was merged in. Do you have casting your eyes over it, I don't want to try myself and get it wrong 🙈 |
|
Shouldnt be needed now the other has merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theres overlap with PR #841 here but I wanted to push up as conversation on it seems to have stalled.
This fixes up a few issues I've found on discounts:
One thing I've noticed in testing is that percentage discounts don't apply a cart level discount value (
cartDiscountAmount) in the way fixed discounts do. Is this intentional?