Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix [0.2] - Fix duplicate language code on tests #802

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

alecritson
Copy link
Collaborator

Currently there is a recurring issue where a test will fail due to duplicate language codes. This should solve it.

@vercel
Copy link

vercel bot commented Jan 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lunar-docs ✅ Ready (Inspect) Visit Preview Jan 12, 2023 at 8:33AM (UTC)

@glennjacobs
Copy link
Contributor

glennjacobs commented Jan 12, 2023 via email

@alecritson
Copy link
Collaborator Author

alecritson commented Jan 12, 2023

How does it solve it?

On Thu Jan 12, 2023, 08:34 AM GMT, Alec Ritson @.> wrote: @alecritson https://github.com/alecritson requested your review on: #802 <#802> Hotfix [0.2] - Fix duplicate language code on tests. — Reply to this email directly, view it on GitHub <#802 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE6B3ZQS6VMYZIUYAKBLSLWR66YHANCNFSM6AAAAAATY65VIQ. You are receiving this because your review was requested.Message ID: @.>

The way Laravel works with refreshing the db it doesn't always purge the data, so there's a chance that the language already exists with that code, by removing fr and en and letting faker generate it we should be sure to get unique data.

We don't explicitly require fr or en to be set in the tests (from what I can see) so it doesn't make sense to be hard coding it.

@alecritson alecritson merged commit 3deb98b into main Jan 12, 2023
@alecritson alecritson deleted the hotfix/fix-language-code-test branch January 12, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants