Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add remark for custom model definition #1966

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Conversation

wychoong
Copy link
Contributor

when a Lunar model is extended/replaced, the media definition config should be updated. Or standard definition will be used

p/s: not sure should the media definition to change to string alias or internally auto resolve to lunar model fqcn

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 6:25am

@alecritson
Copy link
Collaborator

I think it would be more beneficial if the media definition worked with extended models. My thinking is that you should be able to just remove model extending in one place without having to then update a bunch of config etc in order to remove it if that makes sense.

@wychoong
Copy link
Contributor Author

I think it would be more beneficial if the media definition worked with extended models. My thinking is that you should be able to just remove model extending in one place without having to then update a bunch of config etc in order to remove it if that makes sense.

Totally agree. In config you prefer alias or fqcn?

@alecritson
Copy link
Collaborator

I think it would be more beneficial if the media definition worked with extended models. My thinking is that you should be able to just remove model extending in one place without having to then update a bunch of config etc in order to remove it if that makes sense.

Totally agree. In config you prefer alias or fqcn?

I think alias should be sufficient since that's set up by Lunar so unlikely to cause issues and maybe less confusing for people using extending.

@wychoong
Copy link
Contributor Author

alias should be sufficient

done

@glennjacobs glennjacobs merged commit 1ce7206 into lunarphp:1.x Nov 19, 2024
22 checks passed
@wychoong wychoong deleted the patch-4 branch November 20, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants