-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add remark for custom model definition #1966
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I think it would be more beneficial if the media definition worked with extended models. My thinking is that you should be able to just remove model extending in one place without having to then update a bunch of config etc in order to remove it if that makes sense. |
Totally agree. In config you prefer alias or fqcn? |
I think alias should be sufficient since that's set up by Lunar so unlikely to cause issues and maybe less confusing for people using extending. |
done |
when a Lunar model is extended/replaced, the media definition config should be updated. Or standard definition will be used
p/s: not sure should the media definition to change to string alias or internally auto resolve to lunar model fqcn