Fixes postgres compatibility #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes lunarphp#1849 so that Lunar can be upgraded without issue using PostgreSQL. This has only been manually testing against Postgres 15. The intent of the original version was, no doubt, to be more robust than a simple null check. However the case of a non-valid, non-null value existing in the product_options.label seems to be beyond the scope of a simple script meant to backfill new columns with default data. Implementing a check for an empty object or non-object value is tricky without writting different checks for each DB engines.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alecritson
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1849 so that Lunar can be upgraded without issue using PostgreSQL.
This has only been manually testing against Postgres 15.
The intent of the original version was, no doubt, to be more robust than a simple null check. However the case of a non-valid, non-null value existing in the product_options.label seems to be beyond the scope of a simple script meant to backfill new columns with default data.
Implementing a check for an empty object or non-object value is tricky without writting different checks for each DB engines.