Add attribute check on name attribute on base resource #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Considering we want to move to a dedicated |
|
@alecritson as we've decided not to make the |
|
@alecritson will we also need this for Collection editing etc, or does it only affect Products? |
It's already handled on the collection page. |
glennjacobs
approved these changes
Aug 22, 2024
alecritson
deleted the
lun-85-name-input-fails-when-creating-a-product-if-name-isnt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the name attribute is just
Textinstead ofTranslatedTextthis will fail as the panel is rendering a translated text input, causing the name value to be an array of locales.This PR adds an additional check on the method that fetches the name input so the form data is correct on save.