Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique index to collectionGroup handle #1779

Merged

Conversation

wychoong
Copy link
Contributor

currently it does not have unique check on db level and only the admin form have unique validation.

was writing test suite and not aware of created duplicate group handles and page unable to fetch the correct group attached to products...

Copy link

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 4:08am

@glennjacobs
Copy link
Contributor

@alecritson I guess this is potentially a breaking change, so should be mentioned in the upgrade guide.

@wychoong
Copy link
Contributor Author

added changelog

@alecritson alecritson merged commit 298a8c4 into lunarphp:1.x Jun 6, 2024
22 checks passed
@wychoong wychoong deleted the add-unique-index-to-collection-group-handle branch June 6, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants