Fix/empty attributes #1776
Merged
Fix/empty attributes #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
related to #1772 i think ultimately its down to whether the attribute_data field should keep the field types when the value is empty |
glennjacobs
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error
get_class(): Argument #1 ($object) must be of type object, null giventhis happens when added a new attribute to a resource.
the fix 7b19a0e is to mutate the state during field dehydration to return new field type instance when state is null
formatStateUsingdoesnt set the instance during field hydration as it only apply when the state is not nullother commits are some inconsistency that I found while troubleshooting, it should still works without those commits