Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotifx - Fix mapped attributes return type #1517

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Hotifx - Fix mapped attributes return type #1517

merged 1 commit into from
Jan 30, 2024

Conversation

alecritson
Copy link
Collaborator

Closes #1513

@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview Jan 30, 2024 1:13pm

@alecritson alecritson merged commit bbb0956 into 0.7 Jan 30, 2024
5 of 13 checks passed
@alecritson alecritson deleted the hotfix/fix-mapped-attributes-method branch January 30, 2024 13:24
@szymsza
Copy link

szymsza commented Jan 30, 2024

I'm pretty sure this breaks collections() method, as the Collection there (on line 122) is actually supposed to be Lunar\Models\Collection, not the imported Illuminate\Database\Eloquent\Collection.

@glennjacobs
Copy link
Contributor

I'm pretty sure this breaks collections() method, as the Collection there (on line 122) is actually supposed to be Lunar\Models\Collection, not the imported Illuminate\Database\Eloquent\Collection.

@alecritson can you check this?

@alecritson
Copy link
Collaborator Author

Good spot @szymsza it's been patched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennjacobs glennjacobs glennjacobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception thrown by calling Product.mappedAttributes()
3 participants
@alecritson @szymsza @glennjacobs