Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Add scout searching to pages with searchable models. #1445

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

alecritson
Copy link
Collaborator

No description provided.

@alecritson alecritson requested a review from glennjacobs January 4, 2024 09:28
Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 2:15pm

@alecritson alecritson linked an issue Jan 4, 2024 that may be closed by this pull request
@glennjacobs
Copy link
Contributor

Does this allow Scout to be optional?

@alecritson
Copy link
Collaborator Author

Does this allow Scout to be optional?

I have made some tweaks to make Scout optional via a config setting. I have also refactored things to keep it DRY and added extra checks for when Scout isn't available, even if enabled. This will then fallback to the default if not enabled or unavailable.

@glennjacobs glennjacobs merged commit 418541e into 1.x Jan 4, 2024
15 checks passed
@glennjacobs glennjacobs deleted the feature/scout-searching branch January 4, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Laravel Scout searching
2 participants