Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TaxZone countries, states, postcodes #1424

Merged
merged 19 commits into from
Mar 12, 2024

Conversation

wychoong
Copy link
Contributor

image
image
image

Copy link

vercel bot commented Dec 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 11:33am

@glennjacobs
Copy link
Contributor

@wychoong thanks for this. Did you have any plans to add in the Tax Rates also?

@wychoong
Copy link
Contributor Author

wychoong commented Jan 3, 2024

@wychoong thanks for this. Did you have any plans to add in the Tax Rates also?

no plan to add Tax Rate and Customer Group in this PR for now

@glennjacobs glennjacobs added the enhancement Improvement to existing functionality label Jan 3, 2024
@glennjacobs glennjacobs added this to the v1.0 milestone Jan 3, 2024
@glennjacobs
Copy link
Contributor

@alecritson 5812aa9 seems to have broken the tests, can you fix?

@alecritson
Copy link
Collaborator

@alecritson 5812aa9 seems to have broken the tests, can you fix?

Looks like the change exposed an issue in the test itself, hopefully it's patched up.

@alecritson alecritson merged commit b877dac into lunarphp:1.x Mar 12, 2024
12 checks passed
@wychoong wychoong deleted the feat/taxzone-states branch March 12, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants