PowerSpectrum: improve diagnostic value power spectrum api #695
+349
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoepVanlier
force-pushed
the
lazy_power
branch
11 times, most recently
from
ba1a1a5
to
aea2040
Compare
JoepVanlier
force-pushed
the
lazy_power
branch
from
aea2040
to
7aec2c8
Compare
JoepVanlier
changed the title
JoepVanlier
requested review from
alessiamarcolini,
rpauszek and
hrishikeshkelkar
JoepVanlier
force-pushed
the
lazy_power
branch
from
7aec2c8
to
e3f38c4
Compare
JoepVanlier
force-pushed
the
lazy_power
branch
from
e3f38c4
to
867865e
Compare
JoepVanlier
force-pushed
the
lazy_power
branch
from
867865e
to
8cc0ad8
Compare
JoepVanlier
force-pushed
the
expose_diode_model
branch
from
c7dd04e
to
a11ff69
Compare
JoepVanlier
force-pushed
the
lazy_power
branch
from
8cc0ad8
to
1ee98bd
Compare
Three reasons for doing this - A simpler constructor will allow easier construction of tests. - Keeping track of the high frequency data and performing the downsampling and exclusion/fit ranges lazily will allow us to do multiple analyses without the requirement to always recompute the expensive part (the FFT). - Keeping track of the uncut data will allow us to plot what we excluded.
JoepVanlier
force-pushed
the
lazy_power
branch
from
1ee98bd
to
c37465a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
PowerSpectrum. The benefits of this may not be evident in this PR, but a followup one will have pathological spectra constructed directly rather than ifft'ing the spectrum only to immediately fft it again.Tradeoffs
Increased size
Keeping the high frequency spectrum around does come at a cost, namely the increased memory footprint. For a typical calibration (100 kHz sample rate) this is about 4 MB worth of data per axis for passive, 8 for active.
Downsampling and frequency exclusion ranges
There is one annoying issue with showing the frequency exclusion ranges. Exclusion ranges are applied prior to downsampling, which means that downsampling can subsequently pull a point outside the exclusion ranges into it. This is not really a bug, as this allows us to make cuts smaller than the blocking size, but it can look weird.