Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(flexbox): adding options to valign and halign props to handle spacing more precisely #878

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

larprad
Copy link
Contributor

@larprad larprad commented Sep 22, 2022

General summary

It was not possible in the Flexbox component to use space-around/between/evenly css properties through props.
This PR aims to modify this by providing more options to the vAlign and hAlign props for this component.

Screenshots

v-space-around

v-space-between

h-space-around

h-space-between

Check list

Add/Remove/Update the following check list depending on your submission:

  • (if has style) Add need: review-integration label
  • (if has textual documentation) Add need: review-doc label
  • (if has code) Add need: review-frontend label
  • (if has react) Check through the react dev check list
  • (if fix or feature) Add need: test label
  • (if you need a storybook and/or visual diff) Add need: deploy-chromatic label
    Chromatic builds are available here: https://www.chromatic.com/builds?appId=5fbfb1d508c0520021560f10

Check out the contribution guide for general guidelines for submissions to the design system.

-->

@larprad larprad force-pushed the chore/flexbox-add-styles branch from ed83e38 to 8addd31 Compare September 22, 2022 15:47
@larprad larprad requested a review from gcornut September 22, 2022 15:47
@gcornut
Copy link
Member

gcornut commented Sep 23, 2022

Test OK
New flexbox align options work as expected ✔️

@gcornut gcornut force-pushed the chore/flexbox-add-styles branch from 8addd31 to 4b784c1 Compare September 23, 2022 08:47
@gcornut gcornut merged commit 400aff4 into master Sep 23, 2022
@gcornut gcornut deleted the chore/flexbox-add-styles branch September 23, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants