Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slideshow-controls): put a setState func in a useEffect #233

Merged
merged 1 commit into from
Nov 25, 2019
Merged

fix(slideshow-controls): put a setState func in a useEffect #233

merged 1 commit into from
Nov 25, 2019

Conversation

hchevallier
Copy link
Contributor

General summary

Fix already tested, just needed to be cherry picked on the right branch

Screenshots

Check list

  • (if has style) Add need: review-integration label
  • (if has textual documentation) Add need: review-doc label
  • (if has code) Add need: review-frontend label
  • (if has react) Check through the react dev check list
  • (if fix or feature) Add need: test label

Check out the contribution guide for general guidelines for submissions to the design system.

@hchevallier hchevallier requested a review from Flo5k5 November 25, 2019 09:31
@hchevallier hchevallier requested review from lumautomation and a team as code owners November 25, 2019 09:31
Flo5k5
Flo5k5 approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@Flo5k5 Flo5k5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hchevallier hchevallier merged commit 9110b00 into master Nov 25, 2019
@pidupuis pidupuis deleted the fix/slideshowcontrols branch November 27, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flo5k5 Flo5k5 Flo5k5 approved these changes

@lumautomation lumautomation Awaiting requested review from lumautomation lumautomation is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hchevallier @Flo5k5 @pidupuis