-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(uploader): add component #208
Conversation
59f3dcf
to
14c2abf
Compare
@matmkian I've done the React part. Here is what I added which is not in angular:
Let me know if you are against any of theses. I can implement them in Angular too if you want |
14c2abf
to
ecf4d50
Compare
@gcornut, you're so perfect! If you can implement those changes in the Angularjs version that would be perfect! |
ecf4d50
to
0239eca
Compare
I see a lot of differences with the mockups https://app.zeplin.io/project/5beed1207b5f913ebc61d14e/dashboard?seid=5dadbbbc7ef2d22c514c286b Also AspectRatio.original seems broken (no background and somewhat no bounding box) |
Need to talk about that @FlorentDinet , only did https://app.zeplin.io/project/5beed1207b5f913ebc61d14e/screen/5dbfe0c71ad43e22ffd2e906 and no original aspect ratio |
Ok to discuss, it's a nice start let's merge, and improve later |
b4dab3b
to
14398ed
Compare
General summary
Add uploader component.
Screenshots