feat(text): add whiteSpace support #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armasson
requested review from
lumautomation,
matmkian and
a team
as code owners
armasson
force-pushed
the
feat/add-white-space-customisation-for-text-component
branch
from
4d51744 to
3768d66
Compare
gcornut
force-pushed
the
feat/add-white-space-customisation-for-text-component
branch
from
3768d66 to
f82a9bc
Compare
gcornut
requested changes
Jan 4, 2024
There was a problem hiding this comment.
breaking change on nowrap style (see https://www.chromatic.com/test?appId=5fbfb1d508c0520021560f10&id=65967b5a448b0f720f4762d5)
armasson
force-pushed
the
feat/add-white-space-customisation-for-text-component
branch
2 times, most recently
from
37a1637 to
50cad0c
Compare
gcornut
requested changes
Jan 4, 2024
armasson
force-pushed
the
feat/add-white-space-customisation-for-text-component
branch
from
50cad0c to
a6150e7
Compare
gcornut
approved these changes
Jan 4, 2024
|
Test OK on storybook and in automated visual test ✔️ |
gcornut
deleted the
feat/add-white-space-customisation-for-text-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General summary
Proposition to update the design-system
Textcomponent, and add a newwhiteSpaceproperty, to customise theTextCSS style.This will let the user choose the CSS
white-spaceproperty he want for the text. The use case that motivated this PR was to show theTextstring, with it's formatting intact (line break, spaces, ...) usingwhite-space: pre-wrap.Screenshots
StoryBook: https://50cad0c2--5fbfb1d508c0520021560f10.chromatic.com/ (Chromatic build)⚠️ Outdated commit