Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): fixed closing when mouse is hovering the tooltip text #1034

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

gcornut
Copy link
Member

@gcornut gcornut commented Dec 11, 2023

DSW-47

Make tooltip hoverable for better a11y

StoryBook: https://8b13cc9d--5fbfb1d508c0520021560f10.chromatic.com/ (Chromatic build) ⚠️ Outdated commit

@gcornut gcornut force-pushed the fix/DSW-47-tooltip-hoverable branch from 0676489 to e6be7b3 Compare December 11, 2023 17:52
@gcornut gcornut marked this pull request as ready for review December 11, 2023 17:53
@gcornut gcornut requested review from lumautomation, matmkian and a team as code owners December 11, 2023 17:53
Copy link
Contributor

@Mcourt Mcourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mcourt
Copy link
Contributor

Mcourt commented Dec 14, 2023

Test: OK

✅ Hovering the button displays the tooltip on each story
✅ Once the tooltip is displayed, it can be hovered on each story.
✅ Focusing the button displays the tooltip on each story
✅ Pressing Escape while focusing the button removes the tooltip.

@gcornut gcornut force-pushed the fix/DSW-47-tooltip-hoverable branch from 8b13cc9 to 0993434 Compare December 14, 2023 17:00
@gcornut gcornut merged commit 8150af1 into master Dec 15, 2023
6 checks passed
@gcornut gcornut deleted the fix/DSW-47-tooltip-hoverable branch December 15, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants