feat(design-tokens): update color values #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmkian
force-pushed
the
feat/refine-colors
branch
from
1e9fcd7 to
34ad07b
Compare
|
Chromatic visual diffing: https://www.chromatic.com/build?appId=5fbfb1d508c0520021560f10&number=315 |
gcornut
approved these changes
Nov 28, 2023
| --lumx-tabs-link-emphasis-selected-state-active-theme-dark-border-color: var(--lumx-color-light-N); | ||
| --lumx-text-field-input-min-height: 36px; | ||
| --lumx-text-field-input-padding-horizontal: 12px; | ||
| --lumx-text-field-input-border-radius: 4px; | ||
| --lumx-text-field-input-padding-horizontal: var(--lumx-spacing-unit-medium); |
There was a problem hiding this comment.
spacing medium is not documented, should we ? or is it a barely used value that we do not what to propagate ?
There was a problem hiding this comment.
barely used but we could document it
FlorentDinet
approved these changes
Nov 29, 2023
gcornut
force-pushed
the
feat/refine-colors
branch
from
34ad07b to
6bf75b1
Compare
|
Test OK
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General summary
Update colors for better consistency.
Screenshots
StoryBook: https://34ad07b2--5fbfb1d508c0520021560f10.chromatic.com/ (Chromatic build)⚠️ Outdated commit