feat(lumx-icons): replace twitter logo with x logo

This reverts commit 6dcc77e1f63bc1a0590c3f38473550dffe7f4f1e.
lumapps · Nov 23, 2023 · 18a1cac · 18a1cac
1 parent e5ad9c8
commit 18a1cac
Show file tree

Hide file tree

Showing 12 changed files with 29 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 -   `@lumx/icons`: override & alias system in place. now custom icon fonts are now generated from MDI fonts we extend.
+-   `@lumx/icons`: override Twitter logo to use the new X logo.
 
 ## [3.5.5][] - 2023-11-13
 

diff --git a/packages/lumx-icons/override/alias-icons.js b/packages/lumx-icons/override/alias-icons.js
@@ -356,7 +356,8 @@ module.exports = {
         'npm-variant',
         'npm-variant-outline',
     ],
-    twitter: [
+    'x-twitter': [
+        'twitter',
         // retro-compat v4 aliases:
         'twitter-box',
         'twitter-circle',

diff --git a/packages/lumx-icons/override/generated/aliases.scss b/packages/lumx-icons/override/generated/aliases.scss
@@ -355,9 +355,10 @@
     @extend .mdi-npm;
 }
 
+.mdi-twitter,
 .mdi-twitter-box,
 .mdi-twitter-circle {
-    @extend .mdi-twitter;
+    @extend .mdi-x-twitter;
 }
 
 .mdi-library-video {

diff --git a/packages/lumx-icons/override/generated/aliases.ts b/packages/lumx-icons/override/generated/aliases.ts
@@ -113,10 +113,10 @@ import {
     mdiTextBoxSearch,
     mdiTextBoxSearchOutline,
     mdiTowTruck,
-    mdiTwitter,
     mdiVideoBox,
     mdiVideoBoxOff,
     mdiWallSconceRoundVariant,
+    mdiXTwitter,
     mdiYCombinator,
     mdiYoutubeStudio,
 } from './override';
@@ -303,9 +303,11 @@ export const mdiNpmVariant = mdiNpm;
 
 export const mdiNpmVariantOutline = mdiNpm;
 
-export const mdiTwitterBox = mdiTwitter;
+export const mdiTwitter = mdiXTwitter;
 
-export const mdiTwitterCircle = mdiTwitter;
+export const mdiTwitterBox = mdiXTwitter;
+
+export const mdiTwitterCircle = mdiXTwitter;
 
 export const mdiLibraryVideo = mdiPlayBoxMultiple;
 

diff --git a/packages/lumx-icons/override/generated/fonts/materialdesignicons-webfont.eot b/packages/lumx-icons/override/generated/fonts/materialdesignicons-webfont.eot
diff --git a/packages/lumx-icons/override/generated/fonts/materialdesignicons-webfont.ttf b/packages/lumx-icons/override/generated/fonts/materialdesignicons-webfont.ttf
diff --git a/packages/lumx-icons/override/generated/fonts/materialdesignicons-webfont.woff b/packages/lumx-icons/override/generated/fonts/materialdesignicons-webfont.woff
diff --git a/packages/lumx-icons/override/generated/fonts/materialdesignicons-webfont.woff2 b/packages/lumx-icons/override/generated/fonts/materialdesignicons-webfont.woff2
diff --git a/packages/lumx-icons/override/generated/override.scss b/packages/lumx-icons/override/generated/override.scss
@@ -1,3 +1,7 @@
+.mdi-x-twitter:before {
+    content: '\F0544';
+}
+
 .mdi-google-pages:before {
     content: '\F2BA';
 }
diff --git a/packages/lumx-icons/override/generated/override.ts b/packages/lumx-icons/override/generated/override.ts
@@ -2,3 +2,6 @@ export * from '@mdi/js';
 
 export const mdiGooglePages =
     'm19 3h-6v5l4-1-1 4h5v-6c0-1.1-.9-2-2-2m-2 14-4-1v5h6a2 2 0 002-2v-6h-5m-8 0h-5v6a2 2 0 002 2h6v-5l-4 1m-4-12v6h5l-1-4 4 1v-5h-6c-1.1 0-2 .9-2 2z';
+
+export const mdiXTwitter =
+    'm17.8 2.9h3.1L14.1 10.7 22 21.1H15.8L11 14.8 5.4 21.1h-3L9.6 12.9 2 2.9h6.3l4.3 5.9zm-1 16.4h1.7L7.4 4.8H5.7Z';
diff --git a/packages/lumx-icons/override/override-icons/config.js b/packages/lumx-icons/override/override-icons/config.js
@@ -1,4 +1,9 @@
 module.exports = {
+    'x-twitter': {
+        replace: true,
+        cssCode: '\\F0544',
+    },
+    // Icon restored from MDI v4 to avoid breaking change
     'google-pages': {
         cssCode: '\\F2BA',
     },

diff --git a/packages/lumx-icons/override/override-icons/x-twitter.svg b/packages/lumx-icons/override/override-icons/x-twitter.svg